Giter Site home page Giter Site logo

Comments (5)

johnjung avatar johnjung commented on September 11, 2024

This is now fixed in uchicago-library/bmrc@57d7520 and live on both bmrc-test.lib and bmrc.lib. I'm going to close this issue out, please feel free to re-open it if necessary.

from bmrcportal.

MomoMoses avatar MomoMoses commented on September 11, 2024

awesome!

from bmrcportal.

MomoMoses avatar MomoMoses commented on September 11, 2024

the pages were re-crawled an hour ago, but they still show the error. Here is what they suggest as a fix for the code:
<a href="http://www.w3.org/WAI"> <img src="..." alt="Web Accessibility Initiative"/></a>
The order of things is a little different than ours, is all I can see. Can't imagine why that would matter, can you?
Here's what we have: <a alt="Follow the BMRC on Facebook" href="https://www.facebook.com/1BMRC"> plus an svg element with the image specs and source... thoughts? Wait, I think I may see the logical inconsistency -- it's an alt text for the IMAGE, not for the LINK. They say "link" but they really mean "an image used as a link," I think.

What if we put the alt text in the tag used for the icon, i.e. <i>? Seems like SiteImprove is not up with the latest greatest cool web dev!

This issue, since it occurs on almost every page, really drags down the score... :(

from bmrcportal.

johnjung avatar johnjung commented on September 11, 2024

Ok- this shows up in Siteimprove as "Link without a text alternative." I switched the alt attribute on the <a> elements to an aria-label- as far as I can tell that fixes the issue. Please take a look at the site and at Siteimprove to confirm that this is fixed.

from bmrcportal.

MomoMoses avatar MomoMoses commented on September 11, 2024

I think so! Doesn't show up. :)

from bmrcportal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.