joinfaces/joinfaces

JoinFaces: JSF Spring Boot Starters - JSF inside Spring Boot Application

joinfaces's Issues

Update maven-jar-plugin version to 3.0.0

Add ViewScope Spring Implementation

ClassCastException when HandlerWrappers are added via spring-boot for jetty starter

Referring to https://github.com/spring-projects/spring-boot/blob/50e0bb2d9ca3d4d649ec55d135381102c6b6737d/spring-boot/src/main/java/org/springframework/boot/context/embedded/jetty/JettyEmbeddedServletContainerFactory.java#L166

If either of server header or gzip compression is enabled, HandlerWrappers are added and this line breaks throwing ClassCastException. Server.getHandler() does not return WebAppContext anymore.

My first reaction was adding @Order to JettySpringBootAutoConfiguration but it did not work. Solution would be like;

          Handler[] childHandlersByClass = server.getChildHandlersByClass(WebAppContext.class);
           WebAppContext webAppContext = (WebAppContext) childHandlersByClass[0];

Keep up good work btw! Thanks!

Fix ConditionalOnClass of UndertowSpringBootAutoConfiguration

Add .travisci

Add CdiScopeResolver to support cdi and jsf annotations

Configure pom.xml to enable distribution to maven central

Create UndertowSpringBootAutoConfiguration

Create JettyProperties

Fix starter pom.xml version

Create UndertowProperties

Create JavaxFaces Spring Boot Auto Configuration

configure project structure to enable milestone 1.2.0

Create Primefaces Spring Boot Auto Configuration

Create jsf-springboot-integration module

The JSF Spring Boot Integration module should include code related to integration JSF and Spring Boot.
For example, JSF and CDI annotations to spring scope solution should migrate to it.

Create JavaxFaces Properties

Change project version to 1.1.0-SNAPSHOT

Create Mojarra Spring Boot Auto Configuration

Create jsf-undertow-spring-boot-starter

Create JettySpringBootAutoConfiguration

Create Myfaces Spring Boot Auto Configuration

Rationalize configuration properties

I had a quick look at the code and I can see a lot of different prefixes for the configuration. A few thoughts:

• Maybe it would be nicer if all options were gathered under a common prefix (something like jsf if that makes sense?)
• If splitting the configuration by components is a good thing, maybe we should use the name of the component rather than a package name. This is a bit unusual compared to other libraries.

What do you think?

Create jsf-myfaces-spring-boot-autoconfigure module

Support JSF and CDI annotations automatically

CdiScopeResolver should not be necessary in client applications anymore.

Move OmnifacesCacheProperties to OmnifacesProperties

Create jsf-jetty-spring-boot-starter

Fix ConditionalOnClass of JettySpringBootAutoConfiguration

Create Mojarra Properties

Create jsf-myfaces-spring-boot-starter

Create project structure with pom.xml

Create .gitignore

Add debug information about ConfigurationProperties

All of Properties are used to configure ServletContext.
Debug information when ServletContext would be useful.

Spring Security support

Would you consider to add support Spring Security as well? What I have done before is stripping necessary components from spring-webflow and put inside our project. Using directly spring-webflow is bringing other dependencies that is why we are not using directly using them.

Here is the relevant part of it:

https://github.com/spring-projects/spring-webflow/tree/ae25f24443a1756b1149a95200bbe9f04a24f911/spring-faces/src/main/java/org/springframework/faces/security

Jetty and Undertow support?

Hey,

We are considering to move your project but seems a notice in homepage about tomcat. Is this library working only Tomcat? Ideally a Spring Boot starter would be run with Jetty and Undertow as well.

Thanks for sharing.

Change main package to com.github.persapiens.jsfboot

Create Empty class to force javadoc jar generation

It facilitates Maven Central Repository requirements.

Create jsf-jetty-myfaces-spring-boot-starter

Configure faces-config.xml

Create Omnifaces Spring Boot Auto Configuration

serializeStateServer property of JavaxFacesProperties should be serializeServerState

Original property is javax.faces.SERIALIZE_SERVER_STATE.

Add JsfCdiToSpringTest

Create Servlet Context Configurer Abstraction

Organize submodules pom.xml properties

Create Omnifaces Properties

Create jsf-undertow-myfaces-spring-boot-starter

Remove RequestContextListener definition from MojarraSpringBootAutoConfiguration

RequestContextListener bean definition blocks WebMvcAutoConfigurations RequestContextFilter bean to be defined.

https://github.com/spring-projects/spring-boot/blob/v1.3.5.RELEASE/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/WebMvcAutoConfiguration.java#L184

Hence ServletRequestAttributes is not set appropriately (ie. HttpServletResponse is not set).

The very same configuration is present for MyFaces also.

Create Myfaces Properties

Configure spring.factories

Create Primefaces Properties

Move PrimefacesCaptchaProperties to PrimefacesProperties