jokeofweek/jsrogue

The repository for the Coding Cookies "Building a Roguelike in Javascript" tutorial series.

jsrogue's Issues

ROT.js Key Codes

It seems as if ROT.js has changed over the years. The code:

ROT.VK_RETURN

No longer works. You need to change these to:

ROT.KEYS.VK_RETURN

Minor issue, easily fixed, but pointing this out may save some unnecessary frustration.

Minor issue in map.js

In the prototyping of getRandomFloorPosition the y value is calculated using this._width. Doesn't cause any issues with the tutorial, just useful fix in case someone scales their map wider.

Extend function is not working

For those who have problem with extend function: it seems to be missing in current version of ROT.js. You should add this to the top of Game.js file:

Object.prototype.extend = function(a) {
this.prototype=Object.create(a.prototype);
this.prototype.constructor = this;
return this;
};

Bug in `getRandomFloorPosition` for part 4.

Game.Map.prototype.getRandomFloorPosition = function() {
    // Randomly generate a tile which is a floor
    var x, y;
    do {
        x = Math.floor(Math.random() * this._width);
        y = Math.floor(Math.random() * this._width);
    } while(this.getTile(x, y) != Game.Tile.floorTile);
    return {x: x, y: y};
}

You should set the y-coordinate to a random times the map height, not its width.

This may not be the best algorithm for maps with a low ratio of floors, you might want to add a counter to just set a random tile as floor tile if after x tries you still haven't found a spot.