jonallured/appboy

Appboy REST API wrapper for Ruby

appboy's Issues

Opportunity to consolidate?

Hey there, my employer Artsy is a new Braze customer and I need a gem to work with their API. I have some bandwidth during work hours to help improve things about the gem I use so I'm trying to figure out where to put that effort.

After some research, I see 4 different Braze client gems:

https://rubygems.org/gems/appboy => https://github.com/DynamoMTL/appboy
https://rubygems.org/gems/braze_ruby => https://github.com/justinboltz/braze_ruby
https://rubygems.org/gems/braze => https://gitlab.com/mtchavez/braze
https://rubygems.org/gems/braze_api => https://github.com/appearhere/braze_api

I was confused about how all these projects related to each other but I think there might be an opportunity to consolidate at least DynamoMTL/appboy and justinboltz/braze_ruby since the latter is a fork of the former. What do people think of this? What would it take to consolidate our efforts?

The other two seem unrelated but I'd certainly invite those peeps to participate in a single effort!

Going to ping a few contributors on both projects that might have strong feelings (feel free to add others I miss):

@FGoessler
@adayag 👋 ❤️
@hugobast
@joshnuss
@justinboltz
@morgoth
@tborlee
@wenga86

`list_canvas()` currently does not support pagination

Hey, I have been using this gem and with their docs and I need to be able to get canvas that are n pages deep. I see currently the gem does not support pagination and proposed this code change on https://github.com/jonallured/appboy/blob/master/lib/appboy/rest/list_canvas.rb

module Appboy
  module REST
    class ListCanvas < Base
      attr_reader :app_group_id, :sort_direction, :include_archived, :page

      def initialize(app_group_id, options = {})
        @app_group_id = app_group_id
        @sort_direction = options[:sort_direction]
        @include_archived = options[:include_archived]
        @page = options[:page]
      end

      def perform
        http.get '/canvas/list', {
          app_group_id: app_group_id,
          sort_direction: sort_direction,
          include_archived: include_archived,
          page: page
        }.compact
      end
    end
  end
end