jonathanmarvens/atom-language-erlang

Erlang language support for Atom.

atom-language-erlang's Issues

Inner function types in function type specs break highlighting of outer constructs

Screenshot:

This similarly breaks when you just do fun(), though function() works as a workaround for that specific case.

fun() and fun(() -> some_type()) are valid types: https://erlang.org/doc/reference_manual/typespec.html#types-and-their-syntax

Ligature for -> is broken

A similar problem is described in
atom/atom#9372 (comment)

Please correct it.

(Auto-)Indentation of functions not working

New functions, or clauses are indented according to the body of the previous, not the head of it, or base indentation.

Expected behaviour:

f1() ->
  herp.
f2() ->
  derp.

Actual behaviour:

f1() ->
  herp.
  f2() ->
    derp.

it does not help to manually invoke auto-indent either.

Commenting uses /* */

Using Cmd+/

I can break syntax highlighter by placing a struct's close paren differently

See these two screenshots.

Here it's working:

but if I move the closing paren on that record to a new line, syntax higlightling will not work at any point later in the file:

I'm running 1.6.0 on a Mac.

Escaped '%' shouldn't render as comments.

An escaped '%' shouldn't render as a comment.
I'd hollar a PR, but I'm not familiar with this syntax, sorry.

End of Directive Not Matched If It Contains fun()

If a directive (e.g. -spec or -type) contains a fun(...) type definition, the grammar doesn't properly match the end of the directive and treats the entire rest of the file as being part of the directive.

Example:

-module(test).

% this one works fine
-spec a() -> ok.
a() -> ok.

% this directive isn't matched correctly and will never end
-spec b( fun(() -> ok) ) -> not_ok.
b(F) -> not_ok.

indentation doesn't work for complex situations

case expression of
    pattern when guard ->
        body
    end

    try expression of
        pattern when guard ->
            wath
            catch
                pattern when guard ->
                    body
                    after
                        body
                    end  

The indentation doesn't work properly when use command tab to indent the source code. It seems the increaseIndentPattern and decreaseIndentPattern are too simple to match all the cases.

Willing to take over maintainership

Heya @jonathanmarvens, I’d be happy to take over maintaining this. My fork already includes all outstanding PRs merged, but I’d need to be able to publish this to apm, and I think that’s something that you’d need to add me to.

If you don’t feel like doing this, or don’t have the tie I’m happy to maintain my fork under a different name (say atom-language-erlang2 or something, to make clear to people what’s what).

Not trying a hostile take over, just trying to make my fellow Erlanger’s lives a little easier :)

Thanks for all the hard work here!

Package.loadSettings is deprecated.

Store package settings files in the settings/ directory instead of scoped-properties/

Package.loadSettings (..\atom\app-0.192.0\resources\app\src\package.js:547:9)
<unknown> (..\atom\app-0.192.0\resources\app\src\package.js:168:43)

Package.loadSettings is deprecated.

Store package settings files in the settings/ directory instead of scoped-properties/

Package.loadSettings (/Applications/Atom.app/Contents/Resources/app/src/package.js:565:9)
<unknown> (/Applications/Atom.app/Contents/Resources/app/src/package.js:187:43)

publish atom-language-erlang to npm

we're using highlights for the syntax highlighting of npm READMEs now, and have extended it so that grammars can be installed from npm modules:

atom/highlights#14

Would you mind publishing atom-language-erlang to npm, so that we can add support for glsl to our READMEs?

String-hexadecimal values in binaries highlighted as invalid

In Erlang,

<<"\x01">>

is valid notation, equivalent to:

 <<16#01>>

but language-erlang highligths "\x" part as invalid.

BTW, github does same error:

<<"\x01">>

Package.loadSettings is deprecated.

Store package settings files in the settings/ directory instead of scoped-properties/

Package.loadSettings (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:582:9)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:184:43)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:163:15)
Package.load (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:177:12)
PackageManager.loadPackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:355:14)
PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:325:14)

Please add maps defenitions

Autoload for *.escript files

language-erlang should automatically load for *.escript files, in addition to *.erl and *.yaws.