Comments (6)
Yup, it's fine, thanks!
from kdiskmark.
Hi! Thank you. Why is there sys/fcntl.h included? Maybe it is better to use QFile, which is already included in diskdriveinfo.cpp
?
from kdiskmark.
Why is there
sys/fcntl.h
included?
To get O_RDONLY
definition. Should've probably be spelled as simply fcntl.h
though.
Maybe it is better to use QFile, which is already included in
diskdriveinfo.cpp
?
Isn't QFile mainly for reading and writing files, while here we open device node to call ioctl()
on it?
from kdiskmark.
Isn't QFile mainly for reading and writing files, while here we open device node to call
ioctl()
on it?
Oh right, I read the code wrong. I'll create a commit.
from kdiskmark.
Thanks! I forgot to mention that close(2)
needs #include <unistd.h>
but I guess that can wait for another day.
from kdiskmark.
I couldn't check, is it okay now?
from kdiskmark.
Related Issues (20)
- cmake Error - singleapplication does not contain a CMakeLists.txt file HOT 2
- installing Kdiskmark removes too many existing packages HOT 2
- Kdismark HOT 1
- RND4KQ32T16 Bug HOT 2
- CrystalDiskMark compatibility profile HOT 2
- Suggestion: Not using decimals in the results?
- What fio commands are being used? HOT 3
- Using outdated Flatpak runtime versions HOT 3
- Sometimes can't run certain tests.. HOT 5
- Why SingleApplication?.. HOT 1
- Comparable to CrystalDiskMark?.. HOT 1
- kdiskmark is giving inaccurate readings? HOT 2
- `fio` results for RND4K Q32T16 are ~2x higher HOT 1
- Benchmarking non-traditional mount points HOT 4
- "An error occurred while creating the benchmark file" HOT 1
- Feat: set NoCow for Btrfs/Bcachefs
- Android Support
- Why do the benchmark test results between KDiskMark and Gnome Disks not match? HOT 1
- Consider switching to Qt 6 HOT 2
- Can not install on RasbPi4 running raspOS-debian HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kdiskmark.