Giter Site home page Giter Site logo

crazy-hate-group's People

Stargazers

 avatar

Watchers

 avatar

Forkers

lewiscowles1986

crazy-hate-group's Issues

Implement object vars for the magic numbers for nodeType

I know it seems like the value of the node types are numbers, but it would make the code a lot more readable to have keywords from another object instead. That way you have one place to update should they ever change (they probably won't), but more importantly if the code-base ever grew for any reason, the intent would not require comments and changes could be made in one place and filter out to other parts of the application.

Regex simplification

There is a case insensitivity operator you could use for two of the regex's to ensure that merely the combination of i and s characters trigger the replacement.

A slight other side to this issue is that the white-space regex modifier is not used so other whitespace besides a regular space character should not currently be matched, hyphenation is not matched etc.

The last issue is with the word islamic being replaced with non-islamic. If someone like my sister for example noticed the words non-islamic being applied in a clearly islamic context she'd be upset and complain to any publication legitimately using the word islamic. Consider if you will a contrived example

The islamic celebration of Eid

becomes

The non-islamic celebration of Eid

depends on the audience absolutely, but perhaps consider combining uses of the word islamic with words like caliphate, jihad, etc.

Whilst we are on the word jihad, perhaps replace the word jihad with something else?

Google instant-search shows ISIS

I believe because google instant-search is using ajax, the event you are using is perhaps being subverted, but the word ISIS clearly still shows. It would be interesting to see a case implemented for replacing the text in AJAX loaded content (like disqus feeds)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.