jordin/fxcr

Fast approximate chest rendering for Minecraft

fxcr's Issues

Possible Use of Incompatibly-Licensed Code

Hello, I am the developer of Enhanced Block Entities, another Minecraft mod.
I have some reason to believe code from Enhanced Block Entities, which is licensed under the GNU Lesser General Public License v3, has been used directly in FXCR, which is licensed under CC0 a Public Domain license and therefore incompatible.

Example 1

Enhanced Block Entities:

FXCR:

Although one could pass it off as a coincidence, the choice of name and variable type (int) appear very specifically similar to EBE's choice, despite there being little reason to name and type the variable this way.
In EBE specifically the variable was typed as an int, due to me trying to find the correct delay period. That delay period happened to be one tick, meaning that the state of this variable is only ever 1 or 0. I ended up leaving the variable as an int, although reasonably, this variable could have been a boolean type. Yet it happens to be an int in FXCR as well, also with the same variable name.

Example 2

Enhanced Block Entities:

FXCR:

As shown, this appears to be an entire chunk of logic itself which appears to be an exact mirror of that used in EBE. The logic treats rebuildScheduler as a counter, as that was its original purpose in EBE. However as stated before, the maximum value of rebuildScheduler is only ever 1, meaning that this counter logic has no reason to exist, even in EBE. It remains in EBE vestigially, however happens to also be in FXCR, providing reason to believe it was copied.

Example 3

Enhanced Block Entities:

FXCR:

While the methods do in fact perform the same function, that is not as much of a concern as their bearing the same name. This could be a coincidence as well, however given the previous evidence it doesn't seem likely that it is.

The use of LGPLv3 code from Enhanced Block Entities in CC0 software is not compatible.
Some routes you may be able to take to circumvent this licensing issue may include:

• Relicensing the software to a compatible FOSS license
• Rewriting the file of concern

Anyways, thanks in advance and good luck with the project, I hope to hear a response back soon.