jorikschellekens/lyricist

A browser extension that adds lyrics to youtube.

lyricist's Issues

Catch case of failing promises

When the promise for getting the lyrics fail for any reason no further requests can be made.

Add a button to copy the lyrics to clipboard

getMetadata is no longer a promise

Fix lyric injection problem

This bug also relates to the bug where the lyrics are not loaded on tab change.

Add eslint to the project

There are a few linting issues in the code, which can be easily dealt with by adding eslint.

Add cache for lyrics

There should probably a cache for the lyrics. Possible keys for the lyrics could be the video title or the parsed video title, maybe both could be used.

There would be cases where the parsed title/parsed information can be re-used across different videos.

Use document title instead of video title

With the changes coming in (#1) it might be worthwhile to use the document title over parsing the video title.

Overhaul for the tag parser

The tag parser in its current state is actually broken, the format for how YouTube has the meta data for a video in the description is different; the title is broken into two fields one for artist and one for song.

A small sample script to test that works with the new layout is below. The script works once the description box is expanded.

Array.from(document.getElementById('collapsible').children)
  .map(c => c.innerText)
  .filter(c => c.indexOf('Artist') !== -1 || c.indexOf('Song') !== -1)
  .map(c => c.split('\n'))

Project needs test

This issue is made to track the pull request and all the discussion regarding tests, specifically unit tests.

Clean up the cached mutation handler

The current implementation of the mutation handler has two issues

1. questionable state
2. the events in the mutationList as passed to the handler are chronologically indistinguishable. Repeated evaluations of Date.now() is technically incorrect.

Fix lyrics view on playlists.

The lyrics view with playlists looks janky. Attached example below

Fix metadata extraction from the title

The current way of extracting the artist name and the song title do not account for the the fact that the song title can have dashes in it.

Example Kasabian - Re-wired, with the current approach the the metadata object looks like :-

{
  artist: 'Kasabian - Re',
  title: 'wired',
}