jorrinkievit/tmdb-js

A typesafe API wrapper for the TheMovieDatabase API for Node and the Web

tmdb-js's Issues

Api wrong type

Referencing to https://developer.themoviedb.org/reference/collection-details, CollectionsGetDetailsPart's release_date property should be a string

append_to_response is not typesafe

It would be kind of cool if append_to_response would be typesafe. I came out with the "solution" below (a cast), that is not actually a solution because for example, MoviesGetVideosResponse and MoviesGetImagesResponse are types that have id as one of the properties but, when you append videos or images, you don't get the id and also, MoviesGetImagesResponse doesn't have logos property.

api.v3.movies.getDetails(12, {append_to_response: "videos,images"}).then(movie => {
    movie.videos; // <- Property 'videos' does not exist on type 'MoviesGetDetailsResponse'.
    (movie as MoviesGetDetailsResponse & {videos: MoviesGetVideosResponse}).videos

    movie.images; // <- Property 'images' does not exist on type 'MoviesGetDetailsResponse'.
    (movie as MoviesGetDetailsResponse & {images: MoviesGetImagesResponse}).images
})

A solution would at least be to provide an interface specifically for append_to_response responses that you can use to cast, in the case, movie variable.
But at the end it's really a nice api, good job!

Can't fetch trending

Hi, Thank you so much for this package.
I think I'm facing a problem with v3.trending.getTrending() method, I pass the mediaType and timeWindow, but it seems like the timeWindow value is not added to the URL, resulting in a 404.

Language param is missing

This endpoint

tmdb.v3.trending.getTrending

got "mediaType" and "timeWindow" but language is missing

Npm packages' code tab empty

https://www.npmjs.com/package/tmdb-js-node?activeTab=code it's empty (also web version)

Append to response is not typed anywhere needed

For example, tv show's getDetails is not append to response typed

getDetails: <T extends TVAppendToResponse[]>(tvId: number, params?: TVGetDetailsParams<T>) => Promise<TVGetDetailsResponse>;

but movie's one is

getDetails: <T extends MoviesAppendToResponse[]>(movieId: number, params?: MoviesGetDetailsParams<T>) => Promise<GetDetailsResponse<T>>;

belongs_to_collection is null

when I get a movie details

tmdb.v3.movies.getDetails

the property "belongs_to_collection" is null

TV Show episode is missing "runtime" property

Here we can see that the episode has the runtime but in the api there is no such property