josa42/atom-blame

Show git blame as a gutter in Atom editor

Hi there 👋

Projects

📦 coc.nvim extensions

• coc-go
• coc-sh
• coc-lua
• coc-docker

atom-blame's Issues

"Blame: Toggle" while tooltip is open, leaves the tooltips open and will not go away even when navigating to new files

Performing the "Blame: Toggle" command.
While the commit tooltip is open, leaves the tooltips open and will not go away even when navigating to new files.

Uncaught ReferenceError: sheet is not defined

Reproducing:
Executed command Blame: Toggle

Atom: 1.16.0-beta0 x64
Electron: 1.3.13
OS: Linux Mint
Thrown From: blame package 0.10.2

Stack Trace

Uncaught ReferenceError: sheet is not defined

At /home/hask/data/nextCloud/mirror/.atom/packages/blame/lib/blame-gutter-view.js:262

ReferenceError: sheet is not defined
    at BlameGutterView.setGutterWidth (blame-gutter-view.js:262:5)
    at new BlameGutterView (blame-gutter-view.js:21:10)
    at Object.toggleBlameGutter (init.js:55:16)
    at atom-workspace.blame:toggle (init.js:42:34)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:259:29)
    at /app.asar/src/command-registry.js:3:59
    at Object.didConfirmSelection (/app.asar/node_modules/command-palette/lib/command-palette-view.js:92:28)
    at SelectListView.confirmSelection (/app.asar/node_modules/atom-select-list/src/select-list-view.js:292:20)
    at /app.asar/node_modules/atom-select-list/src/select-list-view.js:64:14)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/app.asar/src/command-registry.js:259:29)
    at /app.asar/src/command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:599:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:390:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/app.asar/src/window-event-handler.js:106:36)
    at /app.asar/src/window-event-handler.js:3:59)

Commands

     -0:54.2.0 pane:move-active-item-to-top-of-stack (input.hidden-input)
  3x -0:50.8.0 pane:show-next-recently-used-item (input.hidden-input)
     -0:49.6.0 pane:move-active-item-to-top-of-stack (input.hidden-input)
     -0:48.5.0 core:move-left (input.hidden-input)
     -0:48.2.0 core:move-down (input.hidden-input)
  2x -0:47.7.0 editor:select-to-end-of-word (input.hidden-input)
     -0:47.1.0 core:paste (input.hidden-input)
     -0:46.5.0 core:move-right (input.hidden-input)
     -0:46.2.0 core:delete (input.hidden-input)
     -0:45.8.0 core:save (input.hidden-input)
     -0:29.4.0 fuzzy-finder:toggle-file-finder (input.hidden-input)
     -0:25.5.0 core:move-down (input.hidden-input)
     -0:24.8.0 core:confirm (input.hidden-input)
     -0:09.3.0 command-palette:toggle (input.hidden-input)
     -0:07.7.0 core:confirm (input.hidden-input)
     -0:06.5.0 blame:toggle (input.hidden-input)

Non-Core Packages

atom-ctags 5.0.0 
atom-sync 0.7.3 
atom-terminal 0.8.0 
autocomplete-ctags 0.4.1 
blame 0.10.2 
build 0.67.0 
build-make 0.13.0 
busy 0.7.0 
cursor-history 0.9.1 
dbg 1.4.0 
dbg-gdb 1.6.0 
editorconfig 2.2.2 
git-control 0.8.2 
git-plus 7.3.3 
highlight-selected 0.12.0 
language-lua 0.9.11 
language-tcl 0.1.2 
linter 1.11.23 
linter-js-yaml 1.2.7 
merge-conflicts 1.4.4 
output-panel 0.1.4 
package-cop 0.2.10 
pretty-json 1.6.1 
rester 1.0.2 
sort-lines 0.14.0 
split-diff 1.2.0 
updater-notify 0.5.5 

Set a custom remote repo URL

Are there any plans to implement linking to remote repos that aren't GitHub/BitBucket?

Multi-line commit messages shown as one line

I have a lot of commits in the form

shorter commit title
- longer commit explanation
- with several line breaks

Right now this extension shows everything in 1 long line, which is sometimes larger than the editor window is wide so it gets cut off.

It would be better to make sure line breaks are processed in the tooltip the same as in the commit message.

Uncaught TypeError: Cannot read property 'add' of null

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.4.0
System: Ubuntu 14.04.3
Thrown From: blame package, v0.9.1

Stack Trace

Uncaught TypeError: Cannot read property 'add' of null

At /home/quincy/.atom/packages/blame/lib/blame-gutter-view.js:275

TypeError: Cannot read property 'add' of null
    at /home/quincy/.atom/packages/blame/lib/blame-gutter-view.js:275:25
    at /home/quincy/.atom/packages/blame/lib/utils/get-commit.js:51:5
    at /home/quincy/.atom/packages/blame/lib/utils/get-commit.js:29:5
    at /home/quincy/.atom/packages/blame/node_modules/git-wrapper/git.js:34:5
    at ChildProcess.exithandler (child_process.js:206:7)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:817:16)
    at Socket.<anonymous> (internal/child_process.js:319:11)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)

Commands

     -5:35 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
     -5:32.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -3:45.7.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
     -3:43.5.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:26.4.0 fuzzy-finder:toggle-file-finder (atom-text-editor.editor.is-focused)
     -0:23.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:20 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:01.6.0 blame:toggle (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "ignoredNames": [
      "*.class"
    ],
    "packagesWithKeymapsDisabled": [
      "bracket-matcher"
    ],
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  },
  "blame": {}
}

Installed Packages

# User
angularjs, v0.3.4
atom-material-syntax, v0.3.0
atom-material-ui, v0.8.1
autocomplete-java, v0.12.4
autocomplete-oracle, v0.3.0
blame, v0.9.1
color-tabs, v0.1.8
docblockr, v0.7.3
git-plus, v5.12.1
java-importer, v1.4.1
language-babel, v2.14.1
language-docker, v1.1.6
language-groovy, v0.5.0
language-salesforce, v0.6.0
linter, v1.11.3
linter-docker, v0.1.2
linter-javac, v1.5.0
minimap, v4.19.0
set-syntax, v0.3.0

# Dev
No dev packages

Blame crased when lines are added or modified in SVN Project

In a SVN project:

1. Open an a file
2. Add / remove one or more lines
3. Toggle Blame

Atom: 1.23.3 x64
Electron: 1.6.15
OS: Windows 10
Thrown From: blame package 1.0.1

Stack Trace

Uncaught TypeError: Cannot read property '0' of undefined

At events.js:160

TypeError: Cannot read property '0' of undefined
    at /packages/blame/node_modules/blamer/src/vcs/svn.js:24:31
    at Array.forEach (native)
    at /packages/blame/node_modules/blamer/src/vcs/svn.js:22:40
    at /packages/blame/node_modules/xml2js/lib/parser.js:303:18)
    at emitOne (events.js:96:13)
    at Parser.emit (events.js:188:7)
    at SAXParser.onclosetag (/packages/blame/node_modules/xml2js/lib/parser.js:261:26)
    at emit (/packages/blame/node_modules/sax/lib/sax.js:624:35)
    at emitNode (/packages/blame/node_modules/sax/lib/sax.js:629:5)
    at closeTag (/packages/blame/node_modules/sax/lib/sax.js:889:7)
    at SAXParser.write (/packages/blame/node_modules/sax/lib/sax.js:1436:13)
    at Parser.exports.Parser.Parser.parseString (/packages/blame/node_modules/xml2js/lib/parser.js:322:31)
    at Parser.parseString (/packages/blame/node_modules/xml2js/lib/parser.js:5:59)
    at Object.exports.parseString (/packages/blame/node_modules/xml2js/lib/parser.js:354:19)
    at parseResult (/packages/blame/node_modules/blamer/src/vcs/svn.js:13:12)
    at /packages/blame/node_modules/blamer/src/vcs/svn.js:48:9
    at ChildProcess.exithandler (child_process.js:214:7)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:885:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)

Commands

     -6:41.7.0 intentions:highlight (input.hidden-input)
     -6:41.5.0 core:paste (input.hidden-input)
     -6:40.8.0 core:save (input.hidden-input)

Non-Core Packages

atom-beautify 0.30.9 
atom-typescript 12.1.1 
atom-underscore 0.1.3 
autocomplete-modules 1.10.0 
blame 1.0.1 
busy-signal 1.4.3 
editorconfig 2.2.2 
file-icons 2.1.16 
goto-definition 1.3.4 
intentions 1.1.5 
linter 2.2.0 
linter-eslint 8.4.1 
linter-sass-lint 1.8.3 
linter-ui-default 1.6.10 
minimap 4.29.7 
svn 0.0.13 
tortoise-svn 0.5.1 

Hover shows HTMLDivElement instead of teh actual div

I assume something changed in the API or something.

Editor freezes when using atom-blame in large files

When using atom-blame on large files (1500+ lines) in a git repository with a long history (2500+ commits) my Editor freezes and I have to kill the process. In smaller files it sometimes takes one or two seconds to load the blame.
I am using 1.13.0 and atom-blame 0.10.2 on GNU/Linux.
Let me know if you need more information.

Random "Not committed yet" in files

I have a large project with a large history.

In some files, when I try to see the blaming I just get "not commited yet" text.

I'm on Windows 10 64 bits
Atom 1.9.8

I don't know what info I can give you, I know it's very little. Let me know if you need anything.

PS: Excellent plugin!

No blame output on super large files (10,000+ lines)

I have a file that is over 10k lines, when using atom-blame in that file I get no output.

I will investigate more when I have time what the exact size limit is. For the mean time I will use the commandline on large files.

Release updates to apm

The tooltip still shows undefined because the version on apm is not up to date 👍

Object.dirname is deprecated.

Argument to path.dirname must be a string

Object.dirname (C:\Users\Tessari Davide\AppData\Local\atom\app-1.14.3\resources\app.asar\src\electron-shims.js:9:10)
Object.git (C:\Users\Tessari Davide\.atom\packages\blame\node_modules\blamer\src\vcs\git.js:22:18)
Blamer.blameByFile (C:\Users\Tessari Davide\.atom\packages\blame\node_modules\blamer\src\Blamer.js:15:32)
exports.default (C:\Users\Tessari Davide\.atom\packages\blame\lib\utils\blame.js:21:10)
BlameGutterView.update (C:\Users\Tessari Davide\.atom\packages\blame\lib\blame-gutter-view.js:118:35)
BlameGutterView.setVisible (C:\Users\Tessari Davide\.atom\packages\blame\lib\blame-gutter-view.js:80:14)

blame not visible when the first in a series of identical blames is above the viewport

When consecutive lines have the same blame, only the first has the blame information visible in the gutter. This is helpful when the first line is visible in the viewport, but an irritant when the first line is not in the viewport: it necessitates scrolling up and down to view the blame of a single line.

Suggestions:

• always-visible blame element for the topmost line in the viewport (e.g. position: absolute; top: 0)
• blame information on every single line as in git blame output (perhaps reduced opacity on repeated lines to de-emphasize repetition)

Uncaught TypeError: Cannot read property '1' of null

1. Open Atom
2. Toggle blame either by right-clicking, or using the command pane

Atom Version: 1.7.4
System: Mac OS X 10.11.5
Thrown From: blame package, v0.10.0

Stack Trace

Uncaught TypeError: Cannot read property '1' of null

At /Users/george.gritsouk/.atom/packages/blame/node_modules/blamer/src/vcs/git.js:11

TypeError: Cannot read property '1' of null
    at convertStringToObject (/Users/george.gritsouk/.atom/packages/blame/node_modules/blamer/src/vcs/git.js:11:23)
    at /Users/george.gritsouk/.atom/packages/blame/node_modules/blamer/src/vcs/git.js:38:20
    at Array.forEach (native)
    at /Users/george.gritsouk/.atom/packages/blame/node_modules/blamer/src/vcs/git.js:36:15
    at ChildProcess.exithandler (child_process.js:216:7)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:818:16)
    at Socket.<anonymous> (internal/child_process.js:319:11)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)

Commands

     -0:01.4.0 blame:toggle (atom-text-editor.editor.is-focused.vim-mode.normal-mode)

Config

{
  "core": {
    "customFileTypes": {
      "html": [
        "tpl.php",
        "tmpl.php",
        "tmpl"
      ],
      "php": [
        "module"
      ]
    },
    "destroyEmptyPanes": false,
    "disabledPackages": [
      "background-tips",
      "symbols-view",
      "deprecation-cop",
      "release-notes",
      "archive-view",
      "autocomplete-atom-api",
      "autoflow",
      "encoding-selector",
      "language-c",
      "language-clojure",
      "language-csharp",
      "language-go",
      "language-mustache",
      "language-objective-c",
      "language-perl",
      "language-toml",
      "link",
      "markdown-preview",
      "open-on-github",
      "package-generator",
      "livestyle-atom",
      "line-ending-selector",
      "bookmarks"
    ],
    "ignoredNames": [
      ".git",
      ".hg",
      ".svn",
      ".DS_Store",
      "._*",
      "Thumbs.db",
      "build/*"
    ],
    "packagesWithKeymapsDisabled": [
      "git-diff"
    ],
    "themes": [
      "one-dark-ui",
      "solarized-dark-syntax"
    ]
  }
}

Installed Packages

# User
angularjs, v0.3.4
atom-ctags, v4.5.2
atom-ternjs, v0.14.1
autocomplete-paths, v1.0.2
blame, v0.10.0
cursor-history, v0.5.9
emmet, v2.4.3
highlight-selected, v0.11.2
language-fish-shell, v1.0.4
language-haml, v0.24.0
linter, v1.11.4
linter-eslint, v7.2.2
linter-haml, v1.2.0
linter-htmlhint, v1.1.4
linter-less, v2.5.0
minimap, v4.24.3
minimap-git-diff, v4.3.1
minimap-highlight-selected, v4.4.0
pretty-json, v1.4.0
project-manager, v2.9.7
relative-numbers, v0.5.1
vim-mode, v0.65.1
vim-surround, v0.8.1

# Dev
No dev packages

Show each commit in its own colour.

As a user I'd like to be supported at seeing which lines were changed in the same commit.
Therefore it would be great to show the background of each blame-line in a colour that is specific for the commit.
Currently the blame plugin only alternates between classes blame-odd and blame-even.
A possible solution would be to use the first 6 character of the commit hash as RGB colours for an X % transparent background colour.

Uncaught Error: Tried to create a gutter with a name that is already in use.

[Enter steps to reproduce below:]

1. install blame
2. uninstall blame (empty gutter)
3. install blame and git-blame
4. hit ctrl + b (while git-blame still installing?)

Atom Version: 1.0.13
System: Mac OS X 10.10.5
Thrown From: blame package, v0.5.1

Stack Trace

Uncaught Error: Tried to create a gutter with a name that is already in use.

At /opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/src/gutter-container.js:36

Error: Tried to create a gutter with a name that is already in use.
  at GutterContainer.module.exports.GutterContainer.addGutter (/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/src/gutter-container.js:36:15)
  at TextEditor.module.exports.TextEditor.addGutter (/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/src/text-editor.js:2613:35)
  at new BlameGutterView (/Users/jluf/.atom/packages/blame/lib/blame-gutter-view.coffee:15:23)
  at Object.module.exports.toggleBlameGutter (/Users/jluf/.atom/packages/blame/lib/init.coffee:34:20)
  at atom-workspace.atom.commands.add.blame:toggle (/Users/jluf/.atom/packages/blame/lib/init.coffee:22:27)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/src/command-registry.js:240:29)
  at /opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/opt/homebrew-cask/Caskroom/atom/1.0.7/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:184:20)

Commands

  4x -1:58.8.0 blame:toggle (atom-text-editor.editor.is-focused)
     -1:37.2.0 settings-view:open (atom-text-editor.editor.is-focused)
     -1:32.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:01.1.0 blame:toggle (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "disabledPackages": [
      "copy-config-info",
      "copy-config-info",
      "autocomplete-css"
    ],
    "themes": [
      "atom-light-ui",
      "atom-light-syntax"
    ]
  },
  "blame": {}
}

Installed Packages

# User
blame, v0.5.1
color-picker, v2.0.11
editorconfig, v1.2.0
emmet, v2.3.12
lisp-paredit, v0.4.6
minimap, v4.13.3
pigments, v0.15.0
sync-settings, v0.6.0

# Dev
No dev packages

Different commit authors in case of pull requets

There's an inconsistency in commit authors in case of pull request.

1. create a pull request as a user A
2. merge it as a user B
3. display blame and hover it

• bubble show correct author (user A)
• line show the user who has merged the request (user B)

When scrolling, a persistent tooltip gets created

While trying out this plugin in Atom v1.12.3 on Windows 7, I ran into the following issue: while hovering over the blame gutter, I scroll down somewhat fast. During that movement, at the top of the screen, a tooltip for one of the commits appears. It looks like I need to relaunch Atom in order to get rid of that tooltip.

Commit messages

This is not a bug, but a feature request: it would be nice to have commit messages when the mouse is over a line in the gutter.

Thank :)

Deprecated selector in `blame/styles/blame.less`

In blame/styles/blame.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor .gutter[gutter-name="blame"], atom-text-editor::shadow .gutter[gutter-name="blame"] => atom-text-editor .gutter[gutter-name="blame"], atom-text-editor.editor .gutter[gutter-name="blame"]

• atom-text-editor .blame-gutter, atom-text-editor::shadow .blame-gutter => atom-text-editor .blame-gutter, atom-text-editor.editor .blame-gutter

• atom-text-editor .blame-gutter .blame-gutter-inner, atom-text-editor::shadow .blame-gutter .blame-gutter-inner => atom-text-editor .blame-gutter .blame-gutter-inner, atom-text-editor.editor .blame-gutter .blame-gutter-inner

• atom-text-editor .blame-gutter .blame-gutter-inner.blame-odd, atom-text-editor::shadow .blame-gutter .blame-gutter-inner.blame-odd => atom-text-editor .blame-gutter .blame-gutter-inner.blame-odd, atom-text-editor.editor .blame-gutter .blame-gutter-inner.blame-odd

• atom-text-editor .blame-gutter .blame-gutter-inner.blame-even, atom-text-editor::shadow .blame-gutter .blame-gutter-inner.blame-even => atom-text-editor .blame-gutter .blame-gutter-inner.blame-even, atom-text-editor.editor .blame-gutter .blame-gutter-inner.blame-even

• atom-text-editor .blame-gutter .blame-gutter-inner:hover, atom-text-editor::shadow .blame-gutter .blame-gutter-inner:hover => atom-text-editor .blame-gutter .blame-gutter-inner:hover, atom-text-editor.editor .blame-gutter .blame-gutter-inner:hover

• atom-text-editor .blame-gutter .blame-gutter-inner:hover .icon, atom-text-editor::shadow .blame-gutter .blame-gutter-inner:hover .icon => atom-text-editor .blame-gutter .blame-gutter-inner:hover .icon, atom-text-editor.editor .blame-gutter .blame-gutter-inner:hover .icon

• atom-text-editor .blame-gutter .blame-gutter-inner .blame-gutter-handle, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .blame-gutter-handle => atom-text-editor .blame-gutter .blame-gutter-inner .blame-gutter-handle, atom-text-editor.editor .blame-gutter .blame-gutter-inner .blame-gutter-handle

• atom-text-editor .blame-gutter .blame-gutter-inner .icon, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon => atom-text-editor .blame-gutter .blame-gutter-inner .icon, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon

• atom-text-editor .blame-gutter .blame-gutter-inner .icon-copy, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon-copy => atom-text-editor .blame-gutter .blame-gutter-inner .icon-copy, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon-copy

• atom-text-editor .blame-gutter .blame-gutter-inner .icon-copy::before, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon-copy::before => atom-text-editor .blame-gutter .blame-gutter-inner .icon-copy::before, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon-copy::before

• atom-text-editor .blame-gutter .blame-gutter-inner .icon-copy:hover, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon-copy:hover => atom-text-editor .blame-gutter .blame-gutter-inner .icon-copy:hover, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon-copy:hover

• atom-text-editor .blame-gutter .blame-gutter-inner .icon-link, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon-link => atom-text-editor .blame-gutter .blame-gutter-inner .icon-link, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon-link

• atom-text-editor .blame-gutter .blame-gutter-inner .icon-link::before, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon-link::before => atom-text-editor .blame-gutter .blame-gutter-inner .icon-link::before, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon-link::before

• atom-text-editor .blame-gutter .blame-gutter-inner .icon-link:hover, atom-text-editor::shadow .blame-gutter .blame-gutter-inner .icon-link:hover => atom-text-editor .blame-gutter .blame-gutter-inner .icon-link:hover, atom-text-editor.editor .blame-gutter .blame-gutter-inner .icon-link:hover

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

All blames from folded code shown on top of each other

If you fold code, this happens in blame!

This also happens the better-git-blame package, but not in the git-blame package.

Support Mercurial and Subversion

It looks like you use blamer as a tool to get the blame information. That looks like it already supports SVN. It would be awesome if this tool supported that as well as HG.

Ref: https://github.com/kucherenko/blamer/blob/master/src/Blamer.js

Uncaught TypeError: Cannot read property 'add' of null

Blame panel empty

For all files, the panel is empty upon toggling.

Windows 7, atom-blame v0.10.0, Atom 1.7.0-beta4, no console errors.

Uncaught Error: Cannot decorate a destroyed marker

1. Modify a file
2. Save modifications

Randomly throws an error

Atom: 1.40.1 x64
Electron: 3.1.10
OS: Mac OS X 10.14.6
Thrown From: blame package 1.1.0

Stack Trace

Uncaught Error: Cannot decorate a destroyed marker

At /Applications/Atom.app/Contents/Resources/app/static/<embedded>:11

Error: Cannot decorate a destroyed marker
    at DecorationManager.decorateMarker (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:519139)
    at TextEditor.decorateMarker (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:11:27540)
    at BlameGutterView.addMarker (/packages/blame/lib/blame-gutter-view.js:177:17)
    at /packages/blame/lib/blame-gutter-view.js:115:14
    at Array.forEach (<anonymous>)
    at /packages/blame/lib/blame-gutter-view.js:100:27
    at /packages/blame/lib/provider/git/get-blame.js:43:7)
    at DestroyableTransform.emit (events.js:187:15)
    at endReadableNT (/packages/blame/node_modules/split-transform-stream/node_modules/readable-stream/lib/_stream_readable.js:1010:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

Commands

     -0:09.2.0 core:move-to-top (input.hidden-input)
     -0:07.1.0 editor:newline (input.hidden-input)
     -0:07.1.0 core:paste (input.hidden-input)
     -0:06.9.0 core:save (input.hidden-input)

Non-Core Packages

activate-power-mode 2.7.0 
atom-beautify 0.33.4 
atom-ide-ui 0.13.0 
auto-detect-indentation 1.3.0 
blame 1.1.0 
busy-signal 2.0.1 
emmet 2.4.3 
es6-javascript 1.0.0 
file-icons 2.1.35 
ide-ruby 0.4.0 
intentions 1.1.5 
linter 2.3.1 
linter-eslint 8.5.5 
linter-sass-lint 1.9.0 
linter-ui-default 1.8.0 
minimap 4.29.9 
npm-install 4.0.4 
react 0.18.0 
react-es6-snippets 0.3.0 
react-snippets 1.1.3 

Colorized annotations

Any plans to allow for colorizing and customizing colorizing of the gutter? I might start working on this myself and make a PR. (e.g. author, date, commit in colors)

Uncaught TypeError: Cannot read property '0' of undefined

Tried to annotate svn repository by ctrl+B.

Atom: 1.24.0 x64
Electron: 1.6.16
OS: Ubuntu 16.04.3
Thrown From: blame package 1.0.1

Stack Trace

Uncaught TypeError: Cannot read property '0' of undefined

At events.js:160

TypeError: Cannot read property '0' of undefined
    at /packages/blame/node_modules/blamer/src/vcs/svn.js:24:31
    at Array.forEach (native)
    at /packages/blame/node_modules/blamer/src/vcs/svn.js:22:40
    at /packages/blame/node_modules/xml2js/lib/parser.js:303:18)
    at emitOne (events.js:96:13)
    at Parser.emit (events.js:188:7)
    at SAXParser.onclosetag (/packages/blame/node_modules/xml2js/lib/parser.js:261:26)
    at emit (/packages/blame/node_modules/sax/lib/sax.js:624:35)
    at emitNode (/packages/blame/node_modules/sax/lib/sax.js:629:5)
    at closeTag (/packages/blame/node_modules/sax/lib/sax.js:889:7)
    at SAXParser.write (/packages/blame/node_modules/sax/lib/sax.js:1436:13)
    at Parser.exports.Parser.Parser.parseString (/packages/blame/node_modules/xml2js/lib/parser.js:322:31)
    at Parser.parseString (/packages/blame/node_modules/xml2js/lib/parser.js:5:59)
    at Object.exports.parseString (/packages/blame/node_modules/xml2js/lib/parser.js:354:19)
    at parseResult (/packages/blame/node_modules/blamer/src/vcs/svn.js:13:12)
    at /packages/blame/node_modules/blamer/src/vcs/svn.js:48:9
    at ChildProcess.exithandler (child_process.js:214:7)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at maybeClose (internal/child_process.js:885:16)
    at Socket.<anonymous> (internal/child_process.js:334:11)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at Pipe._handle.close [as _onclose] (net.js:501:12)

Commands

     -2:46.3.0 editor:consolidate-selections (input.hidden-input)
     -2:46.3.0 core:cancel (input.hidden-input)
  2x -2:45.8.0 core:save (input.hidden-input)
  2x -2:40.3.0 editor:auto-indent (input.hidden-input)
     -2:38.9.0 core:select-all (input.hidden-input)
     -2:38.4.0 editor:auto-indent (input.hidden-input)
  4x -2:37.4.0 core:save (input.hidden-input)
  2x -2:27.2.0 core:undo (input.hidden-input)
  3x -2:25.2.0 core:save (input.hidden-input)
     -2:18.3.0 core:select-all (input.hidden-input)
  2x -2:16.7.0 editor:auto-indent (input.hidden-input)
     -2:10.2.0 core:save (input.hidden-input)
  3x -1:57.4.0 git-blame:toggle (input.hidden-input)
     -0:32.3.0 blame:toggle (input.hidden-input)
  3x -0:25.9.0 git-blame:toggle (input.hidden-input)
  2x -0:18.4.0 blame:toggle (input.hidden-input)

Non-Core Packages

blame 1.0.1 
git-blame 1.5.0 
svn 0.0.13 

Allow specifying which browser application to use

I know I can set a custom repository browser URL, but it's not possible to chose which actual web browser application to use for opening these links. It seems like the system's default is used every time.

The issue is that I have two browsers installed, and one of them is only used for work, while the other is my default personal browser. When I click on a link from atom-blame it tries to open my default browser, which doesn't have a session started on the private git repository.

I have set web.browser in my git config but it's not being used by this package.

Click through to a commit URL

Browsing the code for this package, it appears there is support for clicking through to view the corresponding commit at a URL, but I can't find a way to trigger this.

Does this functionality still work? Where should I click to open the commit URL in my browser?

I'm using Atom beta 1.19.0.

Thanks in advance.

Customize gutter view

Was wondering if you can make it so we can customize the gutter view? For instance, instead of the long winded date in the gutter, such as YYYY-MM-DD, I can cutomize it to be MM/DD/YY, Also, instead of the person's full name (that's viewed on GitHub), can customize it to show their username instead.

Make pane resizable

I use large fonts and makes it useless.

Example:

Package.getActivationCommands is deprecated.

Use activationCommands instead of activationEvents in your package.json
Commands should be grouped by selector as follows:

  "activationCommands": {
    "atom-workspace": ["foo:bar", "foo:baz"],
    "atom-text-editor": ["foo:quux"]
  }

Package.getActivationCommands (/usr/share/atom/resources/app.asar/src/package.js:808:9)
Package.hasActivationCommands (/usr/share/atom/resources/app.asar/src/package.js:733:20)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:187:24)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:165:15)
Package.load (/usr/share/atom/resources/app.asar/src/package.js:179:12)
PackageManager.loadPackage (/usr/share/atom/resources/app.asar/src/package-manager.js:372:14)

Pull avatar from GitHub API instead of Gravatar if using GitHub private email

Maybe related: gitextensions/gitextensions#3770.

I'm using GitHub private email in commits. All of them show a default Gravatar image in the popup. You should not check Gravatar if email address is from users.noreply.github.com, because no one can add the no-reply address to their Gravatar profile. Instead, it would be great if you get them from GitHub API.

'Default Width' config invalid in Atom 1.13.x

I'm using Atom Beta 1.13-beta4. They have decided to remove the shadow dom in this version, rending this code invalid:

sheet.innerHTML = `
      atom-text-editor::shadow .gutter[gutter-name="blame"] {
        width: ${this.state.width}px;
      }
    `

It looks like this, regardless of setting.

I can override this for now using this in my stylesheet:

// Customization for atom-blame plugin
atom-text-editor {
  .gutter[gutter-name="blame"] .custom-decorations {
    width: 350px;
  }
}