joseignm/grafa

Faceted Browsing over Wikidata triples

grafa's Issues

Allow searching for classes

I wanted to search for types of cheese (camembert, bleu, etc).

Obviously camembert is a subclass of cheese, not an instance of cheese.

I haven't found a way to search for this.

Type search autocomplete case sensitive

Search by type

Human - no result in the autocomplete
human - several results

It would be more robust to be case insensitive.

Make GraFa more findable by adding it to Wikimedia tool directories

Hi! I'm a fan of GraFa, and I'd like to suggest making it easier to find in the Wikimedia tool ecosystem.

One often-used tool directory to which you can add it, is Hay's tool directory (not only for tools on wmflabs!): https://tools.wmflabs.org/hay/directory/
Instructions here: https://tools.wmflabs.org/hay/directory/#addtool

Self explanatory test fails

I tried looking for Whisky Distilleries as in http://www.bitplan.com/index.php/SPARQL#Whisky_Distilleries_worldwide

but the term Whisky Distillery did not give any result which I find astonishing since https://www.wikidata.org/wiki/Q10373548 has whisky distillery as it's clear text so searching for instance seems to be quite natural.

XSS vulnerability

Raw user content is included into the results page, leading to potential issues with XSS for keyword queries like:

1"><script>alert(150)</script>

A quick solution (not requiring code changes) is to use the following guide: http://www.servletsuite.com/servlets/xssflt.htm

GraFa on web is not working!

Could you please check the server condition?
http://grafa.dcc.uchile.cl/

Existental values for properties

Per the discussion on the Wikidata mailing list with Joachim Neubert, it would be useful to restrict results by entities having any value for a property (including datatype/external properties).

This would require revisiting the caching assumptions and how some of the fields are indexed.

License

Hi, I quickly checked, but wasn't able to find any license statement for the code. Could you please add one? https://www.gnu.org/licenses/license-recommendations.html might be helpful. Thanks!

When choosing a value for a property, sort by number of occurrences in the results

For instance from http://grafa.dcc.uchile.cl/search?keyword=Donald when you click on the + for "instance of", it is hard to find "human" in the dropdown list, even though most of the results have this "instance of".

Cannot filter by label

On the page where the prop filters are on the left, I cannot filter by label. It should be some wildcard input rather than a dropdown.

Search by name - wildcards

Search by name is I assume about label property. It is not clear, if I can use wildcards (and how) or if I can search for partial matches. If I start with wildcard, it throws:
Error while performing query! org.apache.lucene.queryparser.classic.ParseException: Cannot parse 'Titanic': '' or '?' not allowed as first character in WildcardQuery at org.apache.lucene.queryparser.classic.QueryParserBase.parse(QueryParserBase.java:116) at cl.uchile.dcc.facet.web.SearchServlet.doGet(SearchServlet.java:95) at javax.servlet.http.HttpServlet.service(HttpServlet.java:624) at javax.servlet.http.HttpServlet.service(HttpServlet.java:731) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:218) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:110) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:506) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:962) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:452) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1087) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) Caused by: org.apache.lucene.queryparser.classic.ParseException: '*' or '?' not allowed as first character in WildcardQuery at org.apache.lucene.queryparser.classic.QueryParserBase.getWildcardQuery(QueryParserBase.java:743) at org.apache.lucene.queryparser.classic.MultiFieldQueryParser.getWildcardQuery(MultiFieldQueryParser.java:245) at org.apache.lucene.queryparser.classic.MultiFieldQueryParser.getWildcardQuery(MultiFieldQueryParser.java:241) at org.apache.lucene.queryparser.classic.QueryParserBase.handleBareTokenQuery(QueryParserBase.java:841) at org.apache.lucene.queryparser.classic.QueryParser.Term(QueryParser.java:469) at org.apache.lucene.queryparser.classic.QueryParser.Clause(QueryParser.java:355) at org.apache.lucene.queryparser.classic.QueryParser.Query(QueryParser.java:244) at org.apache.lucene.queryparser.classic.QueryParser.TopLevelQuery(QueryParser.java:215) at org.apache.lucene.queryparser.classic.QueryParserBase.parse(QueryParserBase.java:111) ... 23 more

offline

appears to be offline: http://grafa.dcc.uchile.cl/

Placeholder in input field

Arriving at the main interface, one is presented with an input field titled "select a type". Well, there's nothing to really select here, so one has to write something in, but there's no indication of what kind of input is expected here. Perhaps a placeholder attribute to the input field with two or three examples would help bootstrap usage of the tool.

Don't hotlink full size images

Don't hotlink full size images but load thumbnails. You can append ?width=150 to the image url and link to 150px width images, see https://commons.wikimedia.org/wiki/Commons:Reusing_content_outside_Wikimedia/technical#hotlinking . This will help a lot with loading times.