josephcherry/hack-your-future

hack-your-future's Issues

moremaps&filters.js Feedback

line 84 and 86:
// Rounds hours to nearest number with 2 digit decimal and times by twenty (for a 20:- per hour wage).
hours = hours.map((item) => Math.round(item * 100) / 100 * 50);
you wrote times by twenty but you times by 50.

feedback for javascript2Wk1.js

1. Could you make your variables more descriptive? Instead of using x, y , t, maybe you could name them: book list, book list items, book list text.
2. Could you include some comments? So the reader has a better idea of what you are trying to do. Even if it is just writing out the whole question in a comment, that would have helped.
3. Question 3 says to use a "for loop" but you used an "if else" statement.
4. Question 4 asked for a single object with objects inside, not individual objects for each book.

I thought it was very smart how you used an if else statement to iterate through the arrays. I never thought of using it like that before. Even with the letter variables, it was still very clear what you were doing and code worked in the end correct? Great Job Joseph!