joshcomley/sendgrid-netcore

.Net Core port of SendGrid-sharp

sendgrid-netcore's Issues

Issue found in Serialize method under the Utils class.

I have user without core version of library. In my case I am using the template and my parameter dynamically send from my code. When I have used this utility found bug while Serialize the object. Below is the method is used in code

`using (var jsonWriter = new JsonTextWriter(writer))
{
serializer.Serialize(jsonWriter, objectToSerialize);
return jsonWriter.ToString();

//Console.WriteLine(writer.ToString());

}`
This method not created json string properly. So I have change the code as below.

`using (var jsonWriter = new JsonTextWriter(writer))
{
//serializer.Serialize(jsonWriter, objectToSerialize);
//return jsonWriter.ToString();

return JsonConvert.SerializeObject(objectToSerialize).ToString();
    //Console.WriteLine(writer.ToString());

}`

After that all is working fine. It will help some who uses the templates. Please comment is there any better option available that this.

SendGrid.SmtpApi.Utils

public static string Serialize<T>(T objectToSerialize)
        {
            if (objectToSerialize == null)
                throw new ArgumentNullException("A key or value in your X-SMTPAPI header is null.");
            var serializer = JsonSerializer.Create();
            using (var writer = new StringWriter())
            {
                using (var jsonWriter = new JsonTextWriter(writer))
                {
                    serializer.Serialize(jsonWriter, objectToSerialize);
                    // return jsonWriter.ToString(); 
                    return writer.ToString();
                }
            }
        }

Compatibility with ASP.NET Core 1.1.0

Unfortunately, this library is not compatible with the just released version of aspnet core 1.1.0 because of the referenced Microsoft.AspNet.WebApi.Client 5.2.3