Giter Site home page Giter Site logo

Comments (7)

joshtynjala avatar joshtynjala commented on May 11, 2024

I think I've worked around this by manually stopping propagation in an external event listener, but you're right, it should happen automatically.

from flexwires.

dimerman avatar dimerman commented on May 11, 2024

cool.
when can we expect a fix?

awesome lib, BTW

cheers

from flexwires.

dimerman avatar dimerman commented on May 11, 2024

oops.. closed by mistake.

from flexwires.

joshtynjala avatar joshtynjala commented on May 11, 2024

I may commit the change in the near future, but I may not release a new SWC right away.

from flexwires.

dimerman avatar dimerman commented on May 11, 2024

fair enough. thanks!

from flexwires.

joshtynjala avatar joshtynjala commented on May 11, 2024

Actually, looking this over now, I'm not sure this is something I want to change. There are a variety of events where one could initiate the drag of a parent component, and if I were to stop propagation on all of them, I could affect other behavior in an unintended way. Off the top of my head, mouseDown, mouseMove, and whatever the DragManager uses are three places where a drag outside of the WireJack might be started. It could easily become a mess of targets, priorities and event phases, along with multiple calls to stop the propagation.

from flexwires.

dimerman avatar dimerman commented on May 11, 2024

I'm afraid I don't see a scenario where a mouseDown should be handled both by the WireJack and its parent.
If I wanted a container holding a WireJack to get a mouseDown even when clicked on the jack, I would set mouseChildren=false.
IMHO, if the jack is visible and responds to clicks, it should be the sole handler of these clicks...
could you describe a scenario where this does not apply?

could you

from flexwires.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.