Giter Site home page Giter Site logo

joypixels / emojione-assets Goto Github PK

View Code? Open in Web Editor NEW
64.0 64.0 14.0 275.75 MB

[Archived] JoyPixels Emoji Assets now maintained at https://github.com/joypixels/emoji-assets.

Home Page: https://www.joypixels.com

License: Other

CSS 99.99% JavaScript 0.01%

emojione-assets's People

Contributors

caseyahenson avatar christofferok avatar kevinranks avatar maximbaz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

emojione-assets's Issues

Spritemaps: Put placeholder at coordinates (0,0)

The current spritemaps all have a character at position (0, 0). This is problematic when adding CSS classes for an icon that does not exist.

For example, here I tried to create an emoji picker but made a mistake in some of the codepoint classes:

emoji

This results in the first emoji being shown, because there is no offset as defined by the appropriate codepoint class.

While this example is a bit contrived, we had the problem in Threema Web that newer emojis sent by iOS devices would be rendered as policeman because the appropriate emoji was missing:

threema-ch/threema-web#187
threema-ch/threema-web#194
threema-ch/threema-web#199

(The reason was a modifier that was not supported in emojione 2.0...)

To alleviate this issue and to prevent problems with the wrong emoji showing, it would be better to put a placeholder at position (0, 0) of the spritemap, e.g. a light grey square, a box with a quesiton mark, something like that.

Automatically build fonts on every tagged release (I made a Docker image)

Building fonts is a rather complicated process, only a few had time and desire to dig into this and understand how it works, thus you rely on community to provide the fonts for every release. But this whole process shouldn't be that complicated!

I made a Docker image to build fonts (Android/Linux only for now). It has all the dependencies built in, so anyone on any platform can build a font out of the latest emojione-assets using just these two commands:

$ docker pull maximbaz/emojione-fonts-build
$ docker run --rm -v $(pwd):/fonts maximbaz/emojione-fonts-build

However we can do even better!

I'm suggesting to create a Travis job for emojione-assets repository, that will run automatically every time you create a tag, build the font files and attach them to your releases.

I'm totally willing to help with setting this up. Do you like the idea?


I made the Docker image with the idea of adding more target fonts in the future. For example, if someone wants to contribute building emojione-apple.tt*, they only need to add build dependencies to the Dockerfile and the build command itself to the build.sh.


There's obviously a dependency on naming the font files properly #24, for now the files are renamed according to the patterns discovered manually.


/cc @caseyahenson, @mxalbert1996, @vXBaKeRXv

License and distribution of font files

Hello,

I have a question about license and distribution of font files, @caseyahenson, @thinkrick or anyone else, I would very much appreciate an official reply from your team on this matter.

I am investigating a possibility of including ttf-emojione in official package distribution of Arch Linux. For end-users this means simplifying discoverability and installation process of EmojiOne font. From the packaging point of view, the font file will be downloaded from Github releases, added to an archive and stored on archlinux.org servers, where users will be downloading it from.

I would like to confirm with you if this violates your license or not.

I'm confused, because on the one hand your website states "Free license - May not redistribute assets", but on the other hand I'm not sure whether the license even applies to me providing an alternative download location, it feels the end users who downloaded font file are the ones who need to be checking the license.

There is also a precedent of Firefox including Twitter Emoji instead of EmojiOne in the distribution of the browser, but that action might have happened because Mozilla didn't want to implement a way to disable emojis in the browser, while in my case it's purely user's decision whether to install ttf-emojione package or not.

I'm waiting for your response before doing anything further.

v3.1 sprites

We just bought a premium license of emojione today. It seems just after v3.1 shipped. So I'm sure v3.1 sprites are coming, but I was curious what the timeline looks like for that.

Rainbow-colored zodiac symbols

Google's Android O(reo) preview has its zodiac symbol emojis colored much like Emojione 2. You should consider to re-introduce them to version 3.1+.

Google Android O preview (Noto Emoji)

aries taurus gemini cancer leo virgo libra scorpius sagittarius capricorn aquarius pisces

Emojione 2.2 = Emojitwo

Emojione 3.0

Rename png files to include ZWJ

See joypixels/emojione#524 for more details.


In order to correctly build emoji font we have to rename image files to include 200d in them. Otherwise the resulting font cannot distinguish between two separate emojis and a single "complex" emoji:

Font built with current image files:

image

Font built with renamed image files:

image

We have identified the following renaming rules (they can be applied multiple times to the same png file):

-1f308 => -200d-1f308
-1f33e => -200d-1f33e
-1f373 => -200d-1f373
-1f393 => -200d-1f393
-1f3a4 => -200d-1f3a4
-1f3a8 => -200d-1f3a8
-1f3eb => -200d-1f3eb
-1f3ed => -200d-1f3ed
-1f466 => -200d-1f466
-1f467 => -200d-1f467
-1f468 => -200d-1f468
-1f469 => -200d-1f469
-1f48b => -200d-1f48b
-1f4bb => -200d-1f4bb
-1f4bc => -200d-1f4bc
-1f527 => -200d-1f527
-1f52c => -200d-1f52c
-1f5e8 => -200d-1f5e8
-1f680 => -200d-1f680
-1f692 => -200d-1f692
-2642  => -200d-2642
-2695  => -200d-2695
-2696  => -200d-2696
-2708  => -200d-2708
-2764  => -200d-2764

However it is easy to make a manual mistake, plus these rules are not permanent and will change as new emojis are released. That's why I'm asking to consider renaming the files in this repo (unless you have special reasons not to do it).

You have the emoji.json file with base and output codepoints, but neither of them defines the correct file name for a png file. For example, the woman mage file must be named 1f9d9-200d-2640, not 1f9d9-2640 (as per base code points) and not 1f9d9-200d-2640-fe0f (as per full code points). If there is a reason not to rename files, could you at least consider adding the correct file name to the emoji.json, so we can script the renaming process?

Trigger Travis to build ttf font

Congrats on v4 release!

@caseyahenson looks like you tagged a commit from Github UI and that didn't trigger Travis build... Could you please either trigger Travis build manually or tag master and push this tag? You can remove that tag afterwards.

Writing from memory:

git pull
git tag release-4.0
git push --tags

If everything goes as planned, emojione-android.ttf will be attached to your release in 10 mins.

Thanks!

sprites .css files using the wrong media queries for high resolution displays on Firefox

This can be seen in the wild with Firefox here: https://www.emojione.com/emoji/v3. The emojis are blurry on a MacBook Pro Retina display because they aren't using the @2x styles. MDN docs (https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries#-moz-device-pixel-ratio) suggest using min-resolution: 2dppx, but also might need a fallback to 192dpi.

Using Firefox 54.x

Followup, I would submit a PR to help with this, but I wasn't sure how you generate the final .CSS files...is it automated, or do you build them by hand?

No SVG assets?

The repository doesn't currently contain any SVG files, only PNGs. Are SVG assets going to be re-added as the repository is being set up or will EmojiOne 3.0 be limited to PNGs?

SVG images look much crisper than resized PNGs and it's not always possible to stick to the PNGs' native resolutions, so obviously losing that option would be detrimental.

Several missing emoji in 4.x+

I noticed that starting in 4.0 several emoji are missing such as โ„ข๏ธ, ยฉ๏ธ, ยฎ๏ธ, and others. There's a ticket open here:

joypixels/emojione#617

But I think this might be the more appropriate repo.

We're using 32x32 sprites. I see the symbols in the file emojione-sprite-32-symbols.png and I see the data in emoji.json so I'm not sure what's going on.

This is still present in 4.5 and blocking us from upgrading.

Generating sprites with percentage position

I don't see scripts that is used for sprites/css generation, there is scripts in 2.2.7 tag, but not for version 3 as I could find. Actually I want to generate css classes based on percentage instead of fixed position, as related issues is fixed already in google chrome? (or not?) There is related tickets joypixels/emojione#243 joypixels/emojione#220
Anyway, have build scripts in open source (as for 2 version) would be great. Thanks!

Android ttf pistol

I know you have 2 versions of pistol: a more realistic pistol and a water pistol. The android ttf is using the realistic pistol. Are there plans to release a water pistol version of the ttf?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.