jpaulorio/cuda-password-crack

Implementation of a dummy password cracker in CUDA

cuda-password-crack's Issues

Use "C", not C++, unless with intention

password_crack_cpu.cpp is essentially a "C" file. A lot of the ceremony comes from writing it in C++.

Alternatively, update password_crack_cpu.cpp to use C++ as a native language. Examples:

• use new instead of malloc
• use manifest constants instead of macros for fixed values (unless you intent to set them at compile-time)
• do not use <stdio.h>, use <iostream> and friends instead
• same for <string.h>, use the C++ stdlib string
• same for <stdlib.h>, use the C++ equivalents instead

The existing code is classic for "I want to write C, but get better type checking and compiler safety". If that is the intention, use native C++ idioms.