jpmartha/eggsbenedict

EggsBenedict is a library for sharing picture on Instagram written in Swift.

eggsbenedict's Issues

The sendImage method is misleading

Even though the sendImage method is called, the image hasn't been sent to Instagram app yet.

Improvement Error Handling

I think it is not necessary to implement the following:

} catch let sharingFlowError as SharingFlowError {
    completion?(sharingFlowResult: .Failure(self.imagePath, sharingFlowError))
    return

https://github.com/JPMartha/EggsBenedict/blob/develop/EggsBenedict/SharingFlow.swift#L114-L116

The SharingFlowError enumeration adopts the ErrorType protocol.

Send wrong image to Instagram

Even though I sent an image that was different from the sample image, the sample image was displayed on Instagram App.

Implementing the presentOpenInMenuFromBarButtonItem method

What's the difference between the presentOpenInMenuFromRect method and the presentOpenInMenuFromBarButtonItem method?

I'm not sure if I should implement the latter.

I thought the same on my iPhone.
This library has implemented the UIDocumentInteractionController Class' presentOpenInMenuFromRect method.

Raise an exception

1. Call the sendImage method, and the menu is displayed.
2. Tap the "Cancel" button.
3. Call the removeTemporaryImage method, and handle the following error.

Error Domain=NSCocoaErrorDomain Code=4 "“jpmarthaeggsbenedict.ig”を削除できませんでした。" UserInfo={NSFilePath=/private/var/mobile/Containers/Data/Application/(an omission)/tmp/jpmarthaeggsbenedict.ig, NSUserStringVariant=(
    Remove
), NSUnderlyingError=0x1372c62b0 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}}

Displaying the menu is slow

It takes some time to displaying the menu for the first time.

Define protocol

Define protocol following Instagram's sharing flow.

Swift 3

Swift 3 update coming?
Regards

Improvement Error Handling

SharingFlowError

} catch let error as NSError {
    completion?(sharingFlowResult: .Failure(self.imagePath, error))

https://github.com/JPMartha/EggsBenedict/blob/develop/EggsBenedict/SharingFlow.swift#L115-L116

And, I think it is not necessary to implement the following:

guard !self.imagePath.isEmpty else {
    completion?(sharingFlowResult: .Failure(self.imagePath, SharingFlowError.ImagePathIsEmpty))
    return
}

https://github.com/JPMartha/EggsBenedict/blob/develop/EggsBenedict/SharingFlow.swift#L125-L128

No accessible initializers (on branch develop-protocol)

On branch develop-protocol, SharingFlowIGOExclusivegram cannot be constructed because it has no accessible initializers.

Automation generating documentation

Reference

• jazzy
  jazzy uses the SourceKitten.

Remaining the temporary image file

The image file in tmp/ directory isn't removed after sending it to Instagram app.
But if the deinitializer remove it, Instagram app doesn't start.

Adaptation to CocoaPods

I think that it would be better to make adaptation to CocoaPods of this library.

Error Handling

What is the best practice for error handling?