CheckboxChoiceInput breaks compatibility with django 1.5

[jrief]

CheckboxChoiceInput breaks compatibility with django 1.5

[jrief]

Thanks for reporting this.
I've just seen that my unit tests run empty with Django-1.5. This has to be fixed together with this issue.

[rajalokan]

+1

[jrief]

Would it be possible to “steal” the CheckboxChoiceInput from Django-1.6 and backport it to 1.5? I think, this would be the easiest solution, don't you?

[AgDude]

That is an interesting idea, it might work. I haven't looked closely at the dependencies in django.forms.widgets.py to see if anything else changed. The structure of the code generating those widgets is changed substantially, but the api shouldn't have changed at all.

The release notes don't mention the changes at all, and the only change mentioned in the docs has to do with a id attribute on the ul, which is trivial.

[jrief]

Since 1.5 is legacy anyway, why should we invest too much time in supporting that version?
Therefore backporting that widget might be less work than adopting django-angular.

[AgDude]

I agree with not investing a lot of time in it. I would even support documentation for the user on backporting instead of actually including the widgets, but I think that would be more complicated than including them in the project. If it is a user-defined widget, it is going to be more difficult to subclass in djangular.forms.widgets.

[jrief]

Sometimes I have seen that pattern:

try:
    from django.forms.widgets import CheckboxChoiceInput
except ImportError:
    from djangular.forms.widgets.shims import CheckboxChoiceInput

would that work?

[AgDude]

Looks good to me.

[jrief]

I'm very short of time. Would appreciate if you can do it. I'll then merge it into the master tree.
Thanks, Jacob

[AgDude]

I would be happy to do it, but it might be a week or two. I am short of time currently also.

[rajalokan]

Hi @jrief & @AgDude , I can volunteer for this fix. I will need some guidance though. Where can I catch you guys on IRC?

[jrief]

Try to reach me on irc.freenode.net in room django-angular.

[jrief]

I just tried to fix this, please have a look at this branch: https://github.com/jrief/django-angular/tree/backport-django-1.5

Unfortunately the forms are not rendered in django-1.5, there have to be more changes.

[AgDude]

The forms not rendering in that branch is actually due to #61. There is a merged pull request on that issue (from me), which appears to having absolutely nothing to do with label_tags, so I apologize for that. I will add a fix the the label tags on the backport branch.

[AgDude]

I see now that pull request did (sort of) fix the label problem. I wasn't thinking when I looked yesterday, it was against master, so it shows all of the subsequent changes. It appears that change has since been reverted.

[adrienbrunet]

@AgDude It's been a while this ticket is opened but it's pointless if it is solved. I'm closing it now, if you still have some troubles, feel free to reopen it or another one.