The rview from jruesga

Missing Save action during edit

During the edit changes there are following actions available in the menu: Restore, Add, Delete, Rename, Discard, Publish.

Also hitting Back button opens dialog with only Discard/Cancel buttons, but no Save option.

So the only option to proceed editing the next file is publishing the whole change, which is inconvenient.

This is request to add Save action, which corresponds to Save button on Gerrit WebUI during editing a file.

Authenticated access (login) fails on review.typo3.org

Rview reports the username is not valid.
Did they implement something special for review.typo3.org, besides the login-method gerrit uses by default?

Can't switch keyboard layout on edit

I have UTF8 text file with non ascii characters in repository.

In case I try editing this file in app then all characters are displayed ok but I can't switch keabord layout from English to needed one.
I use google keyboard, it has globus button to change layout, clicking on it doesn't change layot in the app.

Issues with creating new changes

At least on Android 7.1.2 (and Gerrit 2.14.1, if it matters), there are several problems with the UI dialog used to create new changes from scratch.

First is that the project completion drop-down only shows the first five projects from the Gerrit instance; typing some initial characters only filters this list, but does not search for additional projects. If the Gerrit instance has more than a few projects, it is not possible to create changes for others than the first few.

Second is that manually typing in the project and branch names doesn't enable the Create button. The button only gets enabled if the project and branch are selected from the dropdown. It should work the same way if the same selections are typed into the box.

ui glitch

Open a gerrit instance, and before its loaded you switch to another one, and before that one is loaded you return to the previous one

ChangeDetailsFragment not loading commits from Fuchsia gerrit

E/ChangeDetailsFragment: Request error
java.util.regex.PatternSyntaxException: Syntax error in regexp pattern near index 9
{change}
^
at java.util.regex.Pattern.compileImpl(Native Method)
at java.util.regex.Pattern.compile(Pattern.java:1340)
at java.util.regex.Pattern.(Pattern.java:1324)
at java.util.regex.Pattern.compile(Pattern.java:946)
at java.lang.String.replaceFirst(String.java:2171)
at com.ruesga.rview.misc.i.b(SourceFile:72)
at com.ruesga.rview.misc.i.a(SourceFile:60)
at com.ruesga.rview.fragments.ChangeDetailsFragment.a(SourceFile:2076)
at com.ruesga.rview.fragments.bf.call(Unknown Source:10)
at b.a.a.a.b.call(SourceFile:37)
at b.a.a.a.d.b(SourceFile:46)
at a.b.e.a(SourceFile:12005)
at a.b.e.e.b.m$a.a(SourceFile:110)
at a.b.e.e.b.m.b(SourceFile:72)
at a.b.e.a(SourceFile:12005)
at a.b.e.e.b.i.a(SourceFile:96)
at a.b.e.e.b.e.b(SourceFile:51)
at a.b.e.a(SourceFile:12005)
at a.b.e.e.b.l$b.run(SourceFile:96)
at a.b.h$a.run(SourceFile:571)
at a.b.e.g.i.run(SourceFile:66)
at a.b.e.g.i.call(SourceFile:57)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
at java.lang.Thread.run(Thread.java:764)

Sometimes wrong value for Code-Review score

Version 1.3.7 (and probably others, I'm new to this app)

The first two reviews in the picture have a Code-Review+2, but shows as +1. Maybe due to the pacing of the votes? You can see the reviews here: https://review.openstack.org/#/c/465804/ and https://review.openstack.org/#/c/453856/

Setting up notifications

Is there anything other then installing the plugin on the server to enable it? Like a custom config?

Nothing is showing up in the notifications for me

Post-merge reviews

On https://review.typo3.org/ users can also give a voting (like +1) by reading or verified even after commit. In rview currently it's possible to add a comment but there are no votes possible.

Sometimes wrong Github avatar

https://github.com/jruesga/rview/blob/master/app/src/main/java/com/ruesga/rview/misc/ModelHelper.java#L180

I don't think that's a reliable way to find the user's Github avatar. I can provide at least one example of the wrong avatar being shown. However, I'm pretty sure there is no better way to do it.

Android O support

NavigationDrawer isn't properly displayed in Android O

CommentLinks without link attribute

In case a comment link doesn't provide a link attribute, just try to extract the link from the html attribute

https://review.typo3.org/#/c/54123/

Open link in app

It would be great if the app would suggest to open gerrit links in the app.

I believe intent filters is what is needed.

Ideally would be that this is triggered by the gerrit links of any profiles but simply doing it for each of the predefined repos would also be a solution.

Edit fails

It remove undesired lines

https://gerrit.omnirom.org/#/c/22096/

Lost edited comment on screen lock

It's quite easy to lose comment being edited:

start edit comment
lock the screen or get distracted for a moment and phone autolocks the screen
unlock the screen but edited comment is lost

Expected behaviour:

comment is not lost and ready to be continued

Deleted files of a commit can't be viewed if logged in

If I'm logged in and I try to view the changes of a deleted file, the snackbar pops up with "Bad request" as message. This seems to happen only if I'm logged in.

Log: http://pastebin.com/raw/nEK1QLLp

Options are duplicated during file edit

Option groups are duplicated during editing file: Navigation, Action, Wrap mode, Text size.

setup wizard

On initial setup screen, when you get to account (where you choose to be anonymous or authenticated), if you change orientation it skips forward to "Well Done" and then crashes.

'wrap line' settings are not applied by default

I'm editing the file in the app.
I have 'wrap lines' settings by default.
On opening the file the first time wrap settings are not applied: to actually wrap lines I have to check 'unwrap lines' and 'wrap lines' again.

Crash on viewing profile

Reproduce:

Open change https://gerrit-review.googlesource.com/#/c/104724 in the app.
Scroll down to last comment from David Pursehouse with abandoning.
Tap on David's avatar to view the profile.

Lost comment on network disconnection

Use case:

start edit review comment
network connection is lost, user is not aware of this
click Save button, but 'Server instance cannot be reached' or 'No network connectivity detected' message appears.
comment is lost.

Expected behaviour:

comment is not lost, it's still possible to copy and save it somewhere (or even app caches it locally and marks it so that its possible to post it later)

Wrong user picture

The following assumes that github username == gerrit username, which is not guaranteed:

rview/app/src/main/java/com/ruesga/rview/misc/ModelHelper.java

Lines 151 to 154 in d3516bd

    
           // Github avatar/identicons 
        
           if (account.username != null) { 
        
               urls.add("https://github.com/" + account.username + ".png?size=" + maxSize); 
        
           }

Crash on opening existing change

I browse changes on Incoming tab and app crashes constantly while tapping specific change.
Backtrace is in attachments. I don't know how to get text backtrace easily, so screen shot attached, text is not copyable in this window.

"5 decades ago"

There's some timezone related issue in incoming patch list view, one patch is even shown as "5 decades ago". I guess this is more or less Jan 2017-Jan 1970? Screenshot attached. My timezone in Gerrit matches TZ on my phone.

Gerrit question

Hi, I would like to ask the following error “Something went wrong RETRY” What's the cause? Is the project authority, or gerrit config？

Look forward to your reply.

Sometimes MenuDrawer becomes unsuable

Press on the drawer items (menu, account switcher, ...) does nothing

Cherry pick "branch" issues

When the list view load there is only one item, if you open it again the list fill properly
The list isn't scrollable
See attachment

Support for HTTP basic authentication

Our Gerrit instance is served behind HTTP basic authentication, it would be great if this could be supported as well.

I tried also connecting using:
https://user:[email protected] without luck.

Add support for ios please :)

It would be really good if there was an ios app for this.

[FEATURE] Add custom scopes to Side Bar

I would really like the ability to add custom searches into the left-side bar

Links fail to open

When I click on a gerrit link Android now suggests to open it in the app (thanks!).

Links such as https://gerrit.wikimedia.org/r/#/c/332088/ and https://gerrit.wikimedia.org/r/#/q/I13518d214811101ec2e592fd3491d41cd5f425eb open fine but for the format https://gerrit.wikimedia.org/r/332088 I get the message Cannot handle link: com.ruesga.rview://changeid/r:332088.

Unsure whether the failing format is due to some settings specifically to the wikimedia setup or if this applies generally. If the former then no worries.

Comment filtering

I'm trying to use the app to review OpenStack code. This gets pretty difficult with openstack/cinder repositories, as we have ~60 CIs autocommenting on each patchset (for example see https://review.openstack.org/#/c/378658/). This makes reading review comments hard. I wonder if it would't be possible to add some configurable filter to filter comments based on username? In this particular case a "^.* CI$" regex would filter out all of the comments from CIs.

OAuth support

I just downloaded rview from Google Play, it looks quite good. Thanks for all the work to make this happen.

One thing I would like to see as an improvement is support for OAuth.I would like to use rview with Wireshark's gerrit ( https://code.wireshark.org/review/ ), where it's possible to log in using a google or github account. It seems that this is not supported by rview, a local account on the gerrit server is required.

RxLoader call onStarted on rotation even when the loader was cleared

Crash on editing file and landscape screen

In case I try editing the file in app in portrait mode then only top half of the screen is displaying file contents. The bottom half is blank.

In case I rotate the phone in landscape mode the app crashes.

Android 6.0.1

Non latin chars are mangled on editing file

I have UTF8 text file with non ascii characters in repository.

In case this file is viewed during review in app all characters are displayed ok.

In case I try editing this file in app then all characters are unreadable like improper encoding is used. Meanwhile all ascii characters are ok.

Fix new line detecction

https://review.lineageos.org/#/c/189259/

Can't login to private gerrit instance

Using version 1.5.5 (After fixing #42) I can add private Gerrit instance with self-signed certificate but can't login.
After enabling authenticated access and filling in Username and Password fields "Invalid username or password" error occurs.

Working as Anonymous coward allows browsing the issues but not commenting them.

I use Gerrit v2.14.2.

Authentication through Github does not work

Our Gerrit installation uses the Github plugin to authenticate users. Rview seems unable to login through it, though I'm not sure what would be needed for that. When I tap on the password reset or sign-in links on the "Authenticated access" page it shows me as logged in already. Maybe an easy fix would be to allow just setting the username and relying on the system browser to have a valid session already?

Tab markup dropped halfway through file

I ran across an issue today when the Rview diff view failed to show that the indentations were using tabs. The same diff viewed through gerrit successfully indicates all of the tabs.

Broken quote visualization

Double quotes seems to broken quote block

https://review.lineageos.org/#/c/189297/

Option to add reviewers after a patch is merged

Gerrit offers support for adding reviewers after a patch is already merged.
That's useful if you want to notify someone of an already merged patch.

Would be cool if that could be integrated into the app :)

Thank you!

Can't select text while editing

Issues seems to be relevant:

after long tap on word text selection markers don't appear while 'cut/paste/copy/select all' pop up appears
'select all' action doesn't select the text at all.

rView does not display the result of the most recent test runs

When issuing a "recheck" comment to gerrit, a new CI test run can be triggered again (without a new patchset). In this case, it seems that rView still displays the results of the first test run (although the results of the other(s) test run(s) can be seen in the comments with "SHOW CI") in the summary showing a list of change, or under "Continuous Integration" in the details of a change.

I'll try to provide an example when I see one again.

Register ./gerrit/. URL for rview

Hi,

Clicking on URL link in Android opens suggestion popup with applications to open the link.
It is possible to open links for gerrit.domain.com/* with rview and not possible to open links for domain.com/gerrit/*.

Is it possible to register URL for rview so that it would open domain.com/gerrit/* links with rview?

Gitweb link doesn't work

There are two links available on the right of commit and parent SHAs in the change screen. Links seem to open browser with gitweb.

Clicking on links results with popup 'No browser detected. Cant open gitweb?p=...' and no browser is opened.

Our repository does have gitweb available.

User dashboards

Support user dashboards:

https://gerrit-review.googlesource.com/Documentation/user-dashboards.html

https://gerrit.tuleap.net/#/projects/All-Projects,dashboards/release-dashboard:release-wip-dashboard

click Rebase on change screen
new popup window appears, the line for commit has text "Subject, change number, or leave empty"
Rebase button is always blank, whether I fill commit or not. So rebase never can be performed.

	// Github avatar/identicons
	if (account.username != null) {
	urls.add("https://github.com/" + account.username + ".png?size=" + maxSize);
	}

jruesga / rview Goto Github PK

rview's People

Stargazers

Watchers

Forkers

rview's Issues

Recommend Projects

Recommend Topics

Recommend Org