jsand3 / ca-projects Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 0.0 9 KB

HTML 94.67% CSS 5.33%

ca-projects's People

Contributors

Watchers

ca-projects's Issues

(Summary) Needs work

Nice work! You're mostly on the right track, but I think that you could benefit from a retry here. Your end product doesn't quite look to spec, and your document is a bit less readable than it ought to be. I'm making separate issues related to each of those points so you can see what I mean - check those out.

It also looks like you have some additional work hanging out in your github repo? I didn't check it out, but unless you're managing a repo-of-repos or other clearinghouse type page, it's usually good to keep it to one project per repo. This helps maximize use of the git CLI.

(Spec) Header size problem

Open up your submission file using your browser and try to examine why the header is not to spec (it's too large but look closer.) I would start troubleshooting here:

ca-projects/Dasmotos/index.html

Lines 10 to 15 in 4360dc8

    
           <body> 
        
           <!-- Header --> 
        
             <div id="header"> 
        
               <h1 class="center-text bold">Dasmoto's Arts & Crafts</h1> 
        
             </div> 
        
           <!-- /End Header -->

(Readability) Use a more explanatory name

As the saying goes "the best comment is a well-named variable" - so name this something that tells you where the CSS hooks into the HTML! Visually this is obvious, but just reading the docs is another story. Getting into this habit now will pay off on larger documents.

ca-projects/Dasmotos/resources/css/style.css

Lines 12 to 21 in 4360dc8

    
           .bg-green { 
        
             background-color: mediumspringgreen; 
        
           } 
        
           .bg-red { 
        
             background-color: lightcoral; 
        
           } 
        
           .bg-blue { 
        
             background-color: skyblue; 
        
           } 
        
           .bold {

jsand3 / ca-projects Goto Github PK

ca-projects's People

Contributors

Watchers

ca-projects's Issues

(Summary) Needs work

(Spec) Header size problem

(Readability) Use a more explanatory name

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	<body>
	<!-- Header -->
	<div id="header">
	<h1 class="center-text bold">Dasmoto's Arts & Crafts</h1>
	</div>
	<!-- /End Header -->

	.bg-green {
	background-color: mediumspringgreen;
	}
	.bg-red {
	background-color: lightcoral;
	}
	.bg-blue {
	background-color: skyblue;
	}
	.bold {