Wrong indentation in shell-mode

[jscheid]

Wrong indentation in shell-mode

[jgeerds]

See also 1115688

[jgeerds]

Whops sorry for the noise. There is alread an open issue addressing my problem: #14

[rrthomas]

So, indent-region should be calling smie-indent-line (as the value of indent-line-function).

If I call indent-line-function, then indeed it reindents to two spaces. However, the smie code in sh-script.el, as far as I can see, only uses sh-indentation, never sh-basic-offset.

The two spaces seem to be specifically after a brace. This uses sh-indent-after-open, which is +, which is sh-basic-offset.

In other words, the SMIE code is sometimes falling back to older values.

So, dtrt-indent should really set both variables (or defer to SMIE, as smie-config-guess changes the rule appropriately, but as you say, that issue already exists). I don't understand why sh-script.el's SMIE code uses sh-indentation and not sh-basic-offset.

Given that the aim is to make dtrt-indent defer to SMIE eventually, the best fix for now is probably to have it set both variables. I'll need to allow multiple variables per mode for that.

[rrthomas]

Since it's easier to implement SMIE support, I've done that instead, and reverted the variable to change to sh-basic-offset for Emacs < 24.4 (without SMIE).