jscruz/carbonintensity

Carbon Intensity Simple Client Library

carbonintensity's Issues

Change time string from Z to +00:00

Is your feature request related to a problem? Please describe.

There is a known 'feature' with python and DateTime strings in that python cannot decode the 'Z' as a timezone. This is because the fromISO method is the inverse of the ToISO method which does not handle 'Z'. https://bugs.python.org/issue35829 refers.

Javascript does handle it correctly as does PHP.

Describe the solution you'd like

Replace 'Z' in the DateTime Strings from the API to '+00:00'. Python can then convert this to a Unix Timestamp else it may treat it as a local time.

https://discuss.python.org/t/parse-z-timezone-suffix-in-datetime/2220 refers

Describe alternatives you've considered

Additional context

Date not updating when calling async_get_data

Describe the bug
The date is not updating when calling method async_get_data. The issue is related on how we set up the default value for from_time in the function:

carbonintensity/carbonintensity/client.py

Lines 9 to 29 in 9b07ca9

	class Client:
	"""Carbon Intensity API Client"""
	def __init__(self, postcode):
	self.postcode = postcode
	self.headers = {"Accept": "application/json"}
	_LOGGER.debug(str(self))
	def __str__(self):
	return "{ postcode: %s, headers: %s }" % (self.postcode, self.headers)
	async def async_get_data(self, from_time=datetime.now()):
	request_url = (
	"https://api.carbonintensity.org.uk/regional/intensity/%s/fw24h/postcode/%s"
	% (from_time.strftime("%Y-%m-%dT%H:%MZ"), self.postcode)
	)
	_LOGGER.debug("Request: %s" % request_url)
	async with aiohttp.ClientSession() as session:
	async with session.get(request_url) as resp:
	json_response = await resp.json()
	return generate_response(json_response)

In Python the value of the default paramters are calculated at definition time.

• Change default parameter to None and handle the value in the function body.