Comments (9)
A few questions:
- are all user tags publicly visible to everyone?
- algorithm of creating
u-jimaek-value
tag. As I understand user only inputs thevalue
part, andu-jimaek-
is autogenerated. To get thejimaek
value:- dashboard BE does a gh api request by gh id during the creation of a new adoption, and stores login in the adopted probe item;
- since gh login may change we also need a cron that will sync gh logins by gh ids.
- validating the city. I see the algorithm as:
- user edits the adopted probe and fulfils 2 inputs: country and city;
- dashboard BE does a geonames request with the country and city values and saves the city, country and coordinates of the best result in the adopted probe item;
- GP API only uses city from the adoption if country from adoption === country from geoip search.
geonames has is 10000 credits daily limit per application, the hourly limit is 1000 credits. 1 search requires 1 credit.
@MartinKolarik @jimaek does that look ok?
from globalping.
A few questions:
- are all user tags publicly visible to everyone?
Yes
algorithm of creating
u-jimaek-value
tag. As I understand user only inputs thevalue
part, andu-jimaek-
is autogenerated. To get thejimaek
value:
- dashboard BE does a gh api request by gh id during the creation of a new adoption, and stores login in the adopted probe item;
We get the username during registration, no need to make new requests during adoption. Just take the value from our DB.
- since gh login may change we also need a cron that will sync gh logins by gh ids.
I dont think we need a cron, we can auto-update usernames on every login into the dashboard
validating the city. I see the algorithm as:
- user edits the adopted probe and fulfils 2 inputs: country and city;
We already have these 2 fields filled with system data. Why do we need to make the country editable at all?
- dashboard BE does a geonames request with the country and city values and saves the city, country and coordinates of the best result in the adopted probe item;
- GP API only uses city from the adoption if country from adoption === country from geoip search.
geonames has is 10000 credits daily limit per application, the hourly limit is 1000 credits. 1 search requires 1 credit.
@MartinKolarik @jimaek does that look ok?
from globalping.
I dont think we need a cron, we can auto-update usernames on every login into the dashboard
Or have a button to do it manually or ignore the case completely for now.
validating the city. I see the algorithm as:
user edits the adopted probe and fulfils 2 inputs: country and city;
We already have these 2 fields filled with system data. Why do we need to make the country editable at all?
We agreed that the user can change the city but not the country. So show the country as we detected it but don't allow changing it. I suppose we need to do #428 first so that the dashboard has the existing values.
from globalping.
I'll skip the update of username for now. And country is required to do the valid geonames search, using readonly country from GP is fine.
from globalping.
Let's do username updates on login. Should be simple and better than nothing or manual actions
from globalping.
Is it better? If the tags change and you use them in a script, it breaks. Manual action seems better.
from globalping.
If we do manual we might as well allow the user to free edit the field. But I don't see the problem, usernames change rarely and it's obvious that you're relying on some random guy. He could delete his tags or enter trash data at any point.
This way we keep things simple and it feels more polished
from globalping.
Disregard 3rd party tags. I meant my own. If I happen to change my username, it will not be immediately clear to me if/when the tags change. "On the next login to the dashboard" is rather arbitrary; we can detect it during the login and show a message + ask for confirmation, but it should not happen in the background. And since as you said, it's a rare thing, I would be ok with leaving this out entirely for now.
from globalping.
I guess it's up to you to either do it now or later, but I still think it must be automated on login at the very least. If you want to add an extra cron it's fine but it just sounds like another component that could break.
Let's just not forget about this functionality, maybe open a new issue?
from globalping.
Related Issues (20)
- Improve dist tests
- Refactor limits
- anti-abuse IPv6 HOT 3
- Issue
- Question about http(s) measurements. HOT 2
- proposed solution for #447 HOT 3
- Add extra TLS data HOT 1
- Add a periodic check for "1 probe per IP" rule
- Allow DNS requests for TLDs and root zone HOT 2
- Improve locations selection
- Upgrade TS and related dependencies
- Add support IPv6 for actions runner HOT 1
- Exclude client errors from APM reporting
- Add IPv6 e2e tests
- Rate limits for GET
- Multi IP handling HOT 8
- Push app names to new relic
- IPv auto selection
- Always send X-Credits-Required on 429 errors
- Add token support to demo page
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from globalping.