Giter Site home page Giter Site logo

Comments (5)

MartinKolarik avatar MartinKolarik commented on July 24, 2024

In terms of the API, I'm thinking of overloading the locations array so that if you pass in a string, it's interpreted as a measurement ID, and the locations are reused from that ID.

Additionally, if locations.length === 1 and it's magic, and it doesn't match anything, as the last step, we should try to interpret it as a measurement ID as well. This will allow users to paste the ID into any of our tools that support the magic mode.

from globalping.

alexey-yarmosh avatar alexey-yarmosh commented on July 24, 2024

measurement with id1 had 20 probes, user starts a new measurement with locations: id1 but API found only 19 of prev probes (1 is disconnected right now). Should api proceed and return OK {probesCount: 19} or try replace missing or send 422?

from globalping.

MartinKolarik avatar MartinKolarik commented on July 24, 2024

OK and 19 but the client must know which probe that is (order of results must match) since the goal is comparing the two runs.

I'm thinking the best way might be keeping the probe in the results array and filling the result with a new probe-level error. Similar to probe timeout but with a different type probably - unavailable or offline ?

from globalping.

alexey-yarmosh avatar alexey-yarmosh commented on July 24, 2024

offline status makes sense. Then, since it is treated as a probe with error, probesCount should be 20 I think.

from globalping.

MartinKolarik avatar MartinKolarik commented on July 24, 2024

Yes.

from globalping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.