jsjbdev / givemehats Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 3.0 312 KB

A hat mod for fabric

License: MIT License

Java 100.00%

givemehats's People

Contributors

Stargazers

Watchers

Forkers

deadyokai speddy88 jlortiz0

givemehats's Issues

Sailor Hat is Broken | Balance Change

I would just like to request a balance change/fix to the sailor hat since I'm not sure if it's intentional.

The sailor hat quite literally enables you to be able to fly. You can place the boat a couple dozen blocks up and virtually fly.

And players who have this load a ridiculous amount of chunks. It nulls the need for an elytra, or anything else for mobility.

Quilted Fabric API Support

Please only if you can (close if you can't / don't want to) compile this mod for the Quilted Fabric API and Quilt Standard Libraries for 1.20.1

Version as of writing is qfapi-7.5.0_qsl-6.1.2_fapi-0.91.0_mc-1.20.1

https://modrinth.com/mod/qsl/version/7.5.0+0.91.0-1.20.1

[Windows Defender] Falsely Identifying a trojan in GiveMeHats

ShetiPhian/Localizations-and-Issues#349

As mentioned to ShetiPhian, people who are downloading my modpack "Another Quality Modpack 2" are getting false negatives of viruses due to Windows Defender sucking ass. They download from CF, and if they have windows defender, 9/10 several mods are getting quarantined. This is preventing them from playing the pack (Not blaming you)

I wanted to give you a heads up, as ShetiPhian also suggested. I will be reporting to the other mods that were falsely identified as a virus. I had roughly over 10 people that complained about this today in our discord and they all downloaded the pack from CF.

Slow fall does not negate fall damage

This happens with Minecraft 1.16 with Give Me Hats! version 1.2.0.

You still take damage when jumping off of a cliff, but you still fall very slowly.

A side note: It's a little too slow for my liking. Something about halfway between normal fall speed and the current speed would probably be a lot better.

Thank you, and excellent work!

Space Hat not working properly

space hat is not giving me the oxygen when outside of water
I know it sounds weird but I'm a merling in origin mod so my breathing is kinda backwards

1.18.2 Equiping any hat will flip other curios slots

When i equip any hat, all the items in the other curios slots flip.
Im using forge, 1.18.2 and the others mods are artifacts, sophisticated backpack and tool belt.

Dwarven Helm Cannot Be Equipped

Found a Dwarven Helm while playing Another Quality Modpack 2 but was unable to equip it. Seems like its missing the whatever tag that allows it to be equipped to the Hat slot.

Hats aren't spawning in chests

I'm unable to find any of the hats in any chests in my modpack. I've attached the list of mods I have. I am using the default config file and we've looted a lot of different kinds of chests. There hasn't been hats in any of them.

modlist.zip

I am using 1.16.5 and have tried a few world gens and even in creative to see and I have yet to find a hat. I played the all of fabric modpack as well and was able to find hats easily, so I'm not sure what's causing the hats not to spawn.

crash on launch[fabric 1.15.2]

crash log:
https://gist.githubusercontent.com/SDUBZ/7d5e401b17b0b3fe420cb853032846e7/raw/d944426734e4011811c1cce34c90608ca806381e/crash-2020-06-03_18.44.18-client.txt

Crashed in the latest version

crash-2020-07-12_21.13.13-client.txt
It is a nice mod but crashed when I was testing mods. I also used these mods: Dark Loading Screen; Fabric API; Fabric Language Kotlin; Inventory Profiles; Mod Menu; Roughly Enough Items & Resources. I've uploaded the crash report. Please check it and have a good day!

Balance issues

So... first off, I love this mod, the idea of giving hats minor passive boosts is great!
But with that said, several hats currently have balance issues that make them way too powerful:

Unsure if visual glitch or not, but the Bowler Hat appears to give infinite speed (the speed buff icon constantly flashes while running and can often stay on screen while not moving)
Bunny Ears offer way too much jump height
Slime Hat completely negates fall damage... most of the time. This makes it incredibly powerful since there are so few ways of stopping fall damage in Minecraft
Cowboy Hat has a nice bonus, though it could be toned down ever so slightly
Floaty Hat offers inconsistent fall damage negation, as it seems to stop working randomly
Dome of the Strider doesn't seem functional currently, but fire resistance as a passive boost would of course be incredibly powerful
The Woolrus combines a potion effect and an effect obtained by mobs, a bit overtuned
Space Helmet provides infinite water breathing passively, making it more powerful than water breathing potions and turtle shells combined
Leprechaun Hat providing the luck buff might make it too powerful when exploring, as the buff boosts gear quality in newly generated areas
The Golem Bucket's effect is funny when it triggers, but the effect may be sending mobs too high up!
Jotaro's Hat applying weakness to mobs makes it almost a necessity in combat, as this effect is hard to come by normally
Dwarven Helm is incredibly overtuned for mining underground, especially when one has an enchanted pickaxe
Awesome Shades give an entire minute(!) of night vision just for crouching, making them incredibly powerful in just about any situation that the other night vision-based hats could be used in, and basically offering infinite triggering of a potion effect

There are some hats I didn't list as their effect is rather fitting (albeit a bit overtuned in some cases).
The issue with these hats being so powerful is that it becomes less a choice of vanity and more of "which overpowered passive boon do I need in this situation?", which takes away from the whole point of hats, which is to look fancy!
There's also the issue of hats dropping so often - you end up having multiple hats and often a lot of duplicates after just a few villages or outposts. This can thankfully be adjusted to some degree in the configuration, though the default should probably be toned down.

What I'd love to see happen is to have some of these hat effects reduced as much as possible and even completely replaced in some cases (Woolrus comes to mind). Hats should provide minor stat boosts and such, not be game-changing buffs the way potions and enchantments are.
And most importantly: an option to make the hats function purely as vanity items would be amazing.
Thank you.

Forge Server Crashing on startup (1.18.2)

Having an issue getting Give Me Hats to work on a Forge Server in 1.18.2
crash-2022-05-03_19.44.02-fml.txt

Exception: java.lang.ClassNotFoundException: com.mojang.blaze3d.vertex.PoseStack

Running the mod on 1.18.2 results in mixin errors

https://pastebin.com/nEq1v7YE

Items drop separately after death

Charm adds a new "Totem of Preserving" that places all items into a totem after death. All modded items except for hats are placed in the totem correctly. Hats drop separately. Not sure if this is a bug on this mod's end, but that seems like the likelier option.

Tippity top hat renders inverted

This happens with Minecraft 1.16 with Give Me Hats! version 1.2.0. This happens with the regular top hat and the fez, as well. I assume it might happen with all of the hats?

Also, they can stack up to 64. You can wear 64 tippity top hats :^)

version in fabric.mod.json not consistent with version

latest still shows 1.0.1

[1.18.2 Fabric] Config not showing new hats

Hello. The last 5 hats are not being generated in the config. does this matter? should I manually put them in? halo, dwarven, viking, etc, etc.

[1.18.2-2.0.1] Give Me Hat's mixin into container loot crashes when containers are not broken by players

I got this report on my mod page about chests/dispensers in my structure are crashing when broken by TNT.
https://www.curseforge.com/minecraft/mc-mods/repurposed-structures#c1117

This is the user's crashlog:
crashlog.txt

I see the crash is caused by a nullpointerexception in a mixin called handler$zno000$loot for the RandomizableContainerBlockEntity class. To the right of it, I see pl:mixin:APP:gmh.mixins.json:LootMixin signaling that a mod with gmh.mixins.json file is involved. So going through the modlist, I see Give Me Hats fits those initials.

Which then led me to here and found that mixin called loot with it's unsafe call to the player which can be null through normal minecraft gameplay:

GiveMeHats/src/main/java/gd/rf/acro/givemehats/mixin/LootMixin.java

Line 48 in 9220062

Random random = player.getRandom();

I think a simple solution here is to replace Random random = player.getRandom(); with Random random = world.getRandom(); since you already check if the world is null or not. That would prevent the crash with any container block being broken by non-player actions. Also, it may be a good idea to prefix your mixin names with your modid. Like instead of this mixin being called "loot", call it "givemehats_loot" which will show up in the tracktrace and make it much easier for users to know what mod's mixin is having trouble.

I hope this helps!

Issue with winged mod

Fabric API 0.19.0+build.398-1.16
MC 1.16.2

give me hats v 1.2.8
winged v 1.4.0

when using Give me hats and wearing wings.

you get this

https://i.imgur.com/dyPFgxs.png

reporting this here and on their issues board just in case.