jsonar/cmake

cmake modules

cmake's Issues

Missing OpenLdap dependencies

When I try to build sonarw with OpenLdap I'm getting these compile errors:

/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:683: error: undefined reference to 'sk_num'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:687: error: undefined reference to 'sk_value'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:1117: error: undefined reference to 'SSL_state_string_long'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:1140: error: undefined reference to 'SSL_alert_type_string_long'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:1141: error: undefined reference to 'SSL_alert_desc_string_long'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:453: error: undefined reference to 'SSL_CTX_set_tmp_rsa_callback'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:180: error: undefined reference to 'sk_new_null'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:185: error: undefined reference to 'sk_free'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:256: error: undefined reference to 'SSLv23_method'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:238: error: undefined reference to 'EVP_cleanup'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:244: error: undefined reference to 'ERR_free_strings'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:212: error: undefined reference to 'SSL_load_error_strings'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:213: error: undefined reference to 'SSL_library_init'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:214: error: undefined reference to 'OpenSSL_add_all_digests'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/tls_o.c:266: error: undefined reference to 'CRYPTO_add_lock'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:184: error: undefined reference to 'sasl_decode'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:194: error: undefined reference to 'sasl_errstring'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:157: error: undefined reference to 'sasl_encode'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:165: error: undefined reference to 'sasl_errstring'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:138: error: undefined reference to 'sasl_getprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:84: error: undefined reference to 'sasl_version'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:117: error: undefined reference to 'sasl_client_init'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:329: error: undefined reference to 'sasl_client_new'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:354: error: undefined reference to 'sasl_dispose'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:358: error: undefined reference to 'sasl_dispose'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:712: error: undefined reference to 'sasl_setprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:714: error: undefined reference to 'sasl_setprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:592: error: undefined reference to 'sasl_client_step'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:647: error: undefined reference to 'sasl_getprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:663: error: undefined reference to 'sasl_getprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:440: error: undefined reference to 'sasl_dispose'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:514: error: undefined reference to 'sasl_setprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:520: error: undefined reference to 'sasl_client_start'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:619: error: undefined reference to 'sasl_errdetail'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:663: error: undefined reference to 'sasl_getprop'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:673: error: undefined reference to 'sasl_dispose'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:926: error: undefined reference to 'sasl_global_listmech'
/home/pablo/jsonar/sonarw/cmake-build-memory/frontend/openldap-prefix/src/openldap/libraries/libldap/cyrus.c:1135: error: undefined reference to 'sasl_setprop'

Adding sasl as depency in OpenLdap SonarExternal.cmake resolves the undefined references to sasl methods, but adding openssl doesn't resolve all the undefined references of this lib.

What I added to SonarExternal.cmake for testing was:

build_openssl()
build_sasl()
ExternalProject_Add(
...
  DEPENDS openssl sasl
...
)
set_target_properties(
...
INTERFACE_LINK_LIBRARIES "openssl::ssl;openssl::crypto;sasl::lib")

SonarW / CMake submodule incongruency due to git tag _devel substring

See https://github.com/jsonar/sonarw/issues/6766 for more information leading up to this issue.

Missing OpenLdap dependencies

pcre and valgrind

right now we fail compilation

arthur@excalibur /local/raid0/build/sonarw43/prod $ make 
[  0%] Performing configure step for 'pcre'
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether make supports nested variables... (cached) yes
checking whether make supports the include directive... yes (GNU style)
checking for gcc... /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc accepts -g... yes
checking for /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc option to accept ISO C89... none needed
checking whether /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc understands -c and -o together... yes
checking dependency style of /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc... gcc3
checking for ar... ar
checking the archiver (ar) interface... ar
checking for gcc... (cached) /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc
checking whether we are using the GNU C compiler... (cached) yes
checking whether /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc accepts -g... (cached) yes
checking for /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc option to accept ISO C89... (cached) none needed
checking whether /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc understands -c and -o together... (cached) yes
checking dependency style of /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc... (cached) gcc3
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C preprocessor... /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for int64_t... yes
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc... /opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld
checking if the linker (/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /opt/rh/devtoolset-9/root/usr/bin/nm -B
checking the name lister (/opt/rh/devtoolset-9/root/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... dlltool
checking how to associate runtime and link libraries... printf %s\n
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /opt/rh/devtoolset-9/root/usr/bin/nm -B output from /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc object... ok
checking for sysroot... no
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for mt... no
checking if : is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc supports -fno-rtti -fno-exceptions... no
checking for /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc option to produce PIC... -fPIC -DPIC
checking if /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc PIC flag -fPIC -DPIC works... yes
checking if /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc static flag -static works... no
checking if /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc supports -c -o file.o... yes
checking if /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc supports -c -o file.o... (cached) yes
checking whether the /usr/bin/ccache /opt/rh/devtoolset-9/root/usr/bin/cc linker (/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld -m elf_x86_64
checking if the linker (/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... no
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/opt/rh/devtoolset-9/root/usr/libexec/gcc/x86_64-redhat-linux/9/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether ln -s works... yes
checking whether the -Werror option is usable... yes
checking for simple visibility declarations... yes
checking for ANSI C header files... (cached) yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking for sys/types.h... (cached) yes
checking for sys/stat.h... (cached) yes
checking dirent.h usability... yes
checking dirent.h presence... yes
checking for dirent.h... yes
checking windows.h usability... no
checking windows.h presence... no
checking for windows.h... no
checking for alias support in the linker... no
checking for alias support in the linker... no
checking string usability... yes
checking string presence... yes
checking for string... yes
checking bits/type_traits.h usability... no
checking bits/type_traits.h presence... no
checking for bits/type_traits.h... no
checking type_traits.h usability... no
checking type_traits.h presence... no
checking for type_traits.h... no
checking for strtoq... yes
checking for long long... yes
checking for unsigned long long... yes
checking for an ANSI C-conforming const... yes
checking for size_t... yes
checking for bcopy... yes
checking for memmove... yes
checking for strerror... yes
checking zlib.h usability... yes
checking zlib.h presence... yes
checking for zlib.h... yes
checking for gzopen in -lz... yes
checking bzlib.h usability... yes
checking bzlib.h presence... yes
checking for bzlib.h... yes
checking for libbz2... yes
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking for PTHREAD_PRIO_INHERIT... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for VALGRIND... no
configure: error: Package requirements (valgrind) were not met:

No package 'valgrind' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables VALGRIND_CFLAGS
and VALGRIND_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
make[2]: *** [frontend/CMakeFiles/pcre.dir/build.make:110: frontend/pcre-prefix/src/pcre-stamp/pcre-configure] Error 1
make[1]: *** [CMakeFiles/Makefile2:1988: frontend/CMakeFiles/pcre.dir/all] Error 2
make: *** [Makefile:163: all] Error 2

libarchive 3.3.3 no longer available

in SonarExternal.cmake

function(build_archive)
  cmake_parse_arguments(ARCHIVE "" "VERSION" "" ${ARGN})
  if (NOT ARCHIVE_VERSION)
    set(ARCHIVE_VERSION 3.3.3)  <--- NO LONGER AVAILABLE
  endif()

I was able to download 3.4.3. That's probably sufficient? Or should we go to the latest/greatest?

---

OpenLdap support for sonarw

@pablojSonar is rewriting our LDAP support, this time using openldap.

He wrote a test program and to compile it he wrote the following CMakeLists.txt:

cmake_minimum_required(VERSION 3.10)

project(ldap_test)

list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/")
find_package(OpenLdap REQUIRED)

include_directories(include)
file(GLOB SOURCES "source/*.cpp")

add_executable(ldap_test ${SOURCES} source/main.cpp)
target_link_libraries(ldap_test ldap)

And this is OpenLdap.cmake:

find_path(OPENLDAP_INCLUDE_DIR ldap.h PATHS
  /usr/include
  /opt/local/include
  /usr/local/include)

find_library(LDAP_LIBRARY ldap)
find_library(LBER_LIBRARY lber)

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(OpenLdap DEFAULT_MSG
  OPENLDAP_INCLUDE_DIR LDAP_LIBRARY LBER_LIBRARY)

set(OPENLDAP_LIBRARIES ${LDAP_LIBRARY} ${LBER_LIBRARY})

mark_as_advanced(
  OPENLDAP_INCLUDE_DIR LDAP_LIBRARY LBER_LIBRARY)

I told him to start changing sonarw using the system library and just doing minimal changes to the cmake, but we need this OpenLDAP library linked statically just like all other libraries.