[Bug]: `boolean-prop-naming` rule throws error

[jlarmstrongiv]

[Bug]: `boolean-prop-naming` rule throws error

[developer-bandi]

There may be an impact due to the fact that typescript version 7 has not been tested, but it is assumed that the case below causes the above error.

type Props = {
  enabled: boolean
}
      
const Hello = (props: Props & {
  semi: boolean
}) => <div />;

So first, i modify the code so that the test case succeeds.

[ljharb]

@developer-bandi just make sure the test fails before the fix is applied :-)

we may need to add testing in v6 and v7 to reproduce it in CI.

[ljharb]

oh it’s definitely a change in the react plugin :-) but we don’t even test on v6 of that parser, let alone v7 (which i didn’t know exists yet) which is why we didn’t catch it.

[ljharb]

Thanks for the report! unfortunately the tests pass for me. I see an easy fix but I can't land it without a failing test case :-/

[ljharb]

what version of the TS eslint parser do you have installed?

[jlarmstrongiv]

@ljharb I’m using @typescript-eslint/[email protected] thanks for looking into it!

Not sure why it’s passing, but the only difference in my project is updating eslint-plugin-react, so it has to be one of the changes in 7.34.1