Comments (7)
With 'react/jsx-closing-bracket-location': ['error', 'tag-aligned']
in eslintrc.js, this is accepted :
const test = <div>
Hello World</div>;
This as well :
<h4><span>
</span></h4>
It could be fixed with something like 'react/jsx-closing-tag-location': ['error', 'tag-aligned']
. react/jsx-closing-tag-location without option is too harsh to be used.
from eslint-plugin-react.
Yet it is implemented in the very similar rule jsx-closing-bracket-location
:
// 'jsx-closing-bracket-location': [1, 'line-aligned']
var x = <Hello
firstName="John"
lastName="Smith"
/>;
var x = function() {
return <Say
firstName="John"
lastName="Smith"
>
Hello
</Say>;
};
For me, it makes sense to have the same options in jsx-closing-tag-location
.
from eslint-plugin-react.
Indeed; it was implemented there before I maintained this plugin.
To be clear, I added the "help wanted" label which means it'll be included once a PR is ready.
from eslint-plugin-react.
I'm confused - how does closing-bracket-notation not already cover this case?
from eslint-plugin-react.
I suppose we could. At this point, i tend to think the only non-harmful style is that multiline jsx is wrapped in parens, and the opening tag starts on a new line, and the closing tag is aligned with the opening tag, and the closing paren is on a line by itself - but since we support line-aligned elsewhere itβd be reasonable to support it here.
from eslint-plugin-react.
Yes, the rule react/jsx-closing-tag-location
imposes the following syntax :
const test = (
<div>
Hello World
</div>
);
but I would rather have the possibility to do it without parens :
const test = <div>
Hello World
</div>;
It is simpler and shorter.
from eslint-plugin-react.
it's more ambiguous, and not as aligned, which to me makes it much less simpler (and "shorter" isn't something that's good to optimize for).
from eslint-plugin-react.
Related Issues (20)
- [Bug]: `no-unknown-property` false-positive without `data-` prefix
- Rule Proposal: `jsx-max-props-per-component` HOT 2
- [Bug]: `boolean-prop-naming` rule throws error HOT 6
- [Bug]: `jsx-no-leaked-render` report `&&` in prop HOT 13
- [Bug]: The `forbidDefaultForRequired` option in the `react/require-default-props` rule does not work as expected HOT 6
- [Bug]: TypeError in version 7.34.1 HOT 1
- `jsx-handler-names` support skipping prop naming checks HOT 2
- [Suggestion]: Drop support for node <16.20 HOT 1
- Proposal for Stringent Type Checking HOT 3
- [Bug]: Support for Eslint 9.0.0? HOT 1
- [Bug]: react/boolean-prop-naming - Cannot read properties of undefined (reading 'properties') HOT 1
- [Bug]: peer dependency error with eslint@9 HOT 1
- [Bug]: An incomprehensible mistake HOT 3
- [help wanted] The functions option (defaultArguments) in the react/require-default-props rule does not work as expected.
- [Bug]: HOT 3
- [Bug]: Properties faulty identified as not declared for types in react-hook-form HOT 1
- [Bug]: checkKeyMustBeforeSpread of react/jsx-key doesn't work when generating array dynamically
- [Bug]: Endless listing cycle HOT 4
- [Bug]: The endless linting cycle HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from eslint-plugin-react.