TSNonNullExpression for non-nullable expressions with array parentheses

[jsx-eslint]

TSNonNullExpression for non-nullable expressions with array parentheses

[steve-py96]

Saw those issues too... which is why I was first doubting the error and assumed that I messed up configuring sth. xd

About versions and origins:

❯ npm ls jsx-ast-utils
######################
├─┬ [email protected]
│ └── [email protected]
└─┬ [email protected]
  └── [email protected] deduped

[steve-py96]

I have some structure like this (cropping out the contextual most irrelevant)

const Component = () => {
  const [{ data, error }, loading, dispatch] = useStore(asyncSelector, shallow)

  useEffect(() => {
    dispatch({
      loading: 'loading',
    })

    loadData().then(([res_error, res_data]) =>
      dispatch((old) => ({
        loading: 'done',
        local: merge(old.local, {
          error: res_error,
          data: res_data,
        }),
      }))
    )
  }, [])

  if (loading !== 'done') return <Loading />
  if (error !== null) return <Error />

  return (
    <>
      <Link className={styles.link} href={data![0].url} target="_blank">
        text
      </Link>

      ...
    </>
  )
} 

The data![0].url in the href-prop is the issue here, commenting it out/replacing it with a hardcoded string hides the warning.

[steve-py96]

Woah that's hella weird, I was building a repro and first I was gonna slap myself cause it didn't throw me the warning, but apparently it only throws on interactive HTMLElements (just a guess after testing <button> and <a> yet), therefore this might be caused somewhere else... (was at least my guess before you just fixed this, you're sanic xd)

Thx for fixing ❤️ , I'll leave the repro link here anyway tho, else RIP the effort! :D
https://stackblitz.com/edit/vitejs-vite-cd1axh?file=src%2FApp.tsx&terminal=lint

[ljharb]

Luckily i was able to repro it just from that one line :-) we weren't handling bracketed member expressions, specifically.

[ljharb]

What version of jsx-ast-utils are you using? v3.2.0 added support for TSNonNullExpression.

See #82, #108, #71.

[ljharb]

hmm, very strange. any idea what code it's warning on?