Giter Site home page Giter Site logo

Comments (7)

ljharb avatar ljharb commented on July 3, 2024 2

It hasn't been, and no, the issue should stay open until it is.

from jsx-ast-utils.

ljharb avatar ljharb commented on July 3, 2024

Be advised this isn't a good UX - things that navigate should only be links and should look like links. Also, the default type of button is submit, so you definitely want an explicit type="button".

That said, "MetaProperty" refers to import.meta and that's not present in your code sample. Are you sure that's the correct sample?

from jsx-ast-utils.

edmaala avatar edmaala commented on July 3, 2024

Oh. I was actually importing the href from a .env file. I'll be updating the sample then.

from jsx-ast-utils.

ljharb avatar ljharb commented on July 3, 2024

ok, then this duplicates #133 (but with much more info, thanks!) and #119.

However, we already have import.meta in our tests, which are passing. Can you perhaps make a repro case, with a repo or a codesandbox?

from jsx-ast-utils.

edmaala avatar edmaala commented on July 3, 2024

Here it is https://codesandbox.io/p/sandbox/meta-property-repro-ml864q?file=%2Ftsconfig.json%3A19%2C38

Here's a screenshot as well.
image

I've also noticed that the error does not show up in the sandbox when I only had the basic Vite and ESLint setup. It only reappeared after I added airbnb and prettier as additional dev dependencies.

from jsx-ast-utils.

edmaala avatar edmaala commented on July 3, 2024

Hi @ljharb . Would just like to know if this has already been resolved. Should I close the issue?

from jsx-ast-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.