jtfell/authorizr

Minimalist authorisation mechanism for node servers

authorizr's Issues

any() and all() not returning expected results.

Hey Jules,

I was getting strange results from the new any/all syntax - so I did a little test.
Here are the results:

Any/all Tester:
(a) isDefinedAsTrue() is defined to return 'true'
    Checking isDefinedAsTrue() with all() returns true
    Checking isDefinedAsTrue() with any() returns false

(b) isDefinedAsFalse() is defined to return 'false'
    Checking isDefinedAsFalse() with all() returns true
    Checking isDefinedAsFalse() with any() returns false

Checks these chained with all() then any().
Results:
  a + b Any: false (should be true)
  a + b All: true (should be false)
  a + a All: true (should be true)
  b + b All: true (should be false)
  a + a Any: false (should be true)
  b + b Any: false (should be false)

The code that generated this output:

console.log(`
      Any/all Tester:
      (a) isDefinedAsTrue() is defined to return 'true'
          Checking isDefinedAsTrue() with all() returns ${await ctx.auth.team(teamId).isDefinedAsTrue().all()}
          Checking isDefinedAsTrue() with any() returns ${await ctx.auth.team(teamId).isDefinedAsTrue().any()}

      (b) isDefinedAsFalse() is defined to return 'false'
          Checking isDefinedAsFalse() with all() returns ${await ctx.auth.team(teamId).isDefinedAsFalse().all()}
          Checking isDefinedAsFalse() with any() returns ${await ctx.auth.team(teamId).isDefinedAsFalse().any()}

      Checks these chained with all() then any().
      Results:
        a + b Any: ${await ctx.auth.team(teamId).isDefinedAsTrue().isDefinedAsFalse().any()} (should be true)
        a + b All: ${await ctx.auth.team(teamId).isDefinedAsTrue().isDefinedAsFalse().all()} (should be false)
        a + a All: ${await ctx.auth.team(teamId).isDefinedAsTrue().isDefinedAsTrue().all()} (should be true)
        b + b All: ${await ctx.auth.team(teamId).isDefinedAsFalse().isDefinedAsFalse().all()} (should be false)
        a + a Any: ${await ctx.auth.team(teamId).isDefinedAsTrue().isDefinedAsTrue().any()} (should be true)
        b + b Any: ${await ctx.auth.team(teamId).isDefinedAsFalse().isDefinedAsFalse().any()} (should be false)
      `);

The definitions in the authorizr entity

isDefinedAsTrue: (ctx, entityId) => {
     return true;
},
isDefinedAsFalse: (ctx, entityId) => {
     return false;
}