juampicarosi/fan-control

Simple shell script to control hdd and cpu fans of macs in linux

fan-control's Issues

missing spaces around "=" operator

lines 72 and 109 will always eval as "true" :

if [ $fan2_manual="0" ]; then

and

if [ $fan3_manual="0" ]; then

should be rewritten as :

if [ "$fan2_manual" = "0" ]; then

and

if [ "$fan3_manual" = "0" ]; then

Line 9 and Line 139 missing '

I am getting a line 9: [: missing ']'
And
Line 139: [: missing ']'
Output when command 'fan' is used.
I am also not getting a response in fan control in 'auto' mode.

Just wanted to say thank you!

Simple and effective, and open source. Thank you!

merge master and mbp ?

I am unsure what mbp branch is, compared to master.

If master has some specificity that mbp does not, would it be possible to list them, so we could merge the whole ?

[question] how to handle different hardware ?

In mbp source, we have some tests on strings like exhaust or master to determine if we check for more fans...

Could we instead check for the existence of /sys/.../fanX_label to easily find everything and do not make any exceptions ? Code would be easier to understand, we could take off many tests, and rely only on /sys/ files for valid arguments.

Note: I did simplify the code coz' I want to expand it, for example to allow to modify different fan variables... If the code structure is easier to read, with functions (no copy/paste/edit of code), it will be easier to add stuff... But it is just an opinion.

2009 Mac mini not working

I type the fan command and get the following output:
cat: /sys/devices/platform/applesmc.768/fan2_label: No such file or directory
cat: /sys/devices/platform/applesmc.768/fan3_label: No such file or directory
Available fans:
master
and when I try to control master (example: fan master 80) , it outputs:
cat: /sys/devices/platform/applesmc.768/fan2_label: No such file or directory
cat: /sys/devices/platform/applesmc.768/fan3_label: No such file or directory
and the fan speed doesn't change