Giter Site home page Giter Site logo

juancarloscp52 / spyglass-improvements Goto Github PK

View Code? Open in Web Editor NEW
3.0 3.0 3.0 13.96 MB

Spyglass Improvements is a mod that add various functionality and improvements to the vanilla minecraft spyglass.

Home Page: https://www.curseforge.com/minecraft/mc-mods/spyglass-improvements

License: Other

Java 99.44% Shell 0.56%
fabric forge minecraft minecraft-mod spyglass vanilla

spyglass-improvements's People

Contributors

juancarloscp52 avatar kimchiloof avatar

Stargazers

 avatar  avatar

Watchers

 avatar

spyglass-improvements's Issues

Initial zoom isn't smooth

When first zooming in, the FOV snaps to whatever increment you had, rather than smoothly going from base FOV to the zoom FOV.
This is just a minor issue, but it can be quite noticeable, especially when the hud still smoothly zooms.

Can't join server with this mod installed

Hi there, I'm building a Forge Server and your mod is the only one stumping me now.

Clients can't connect to a server while they (the client) have the mod installed (Some Forge server mod mismatch BS)
The solution would be to add it to the server so that the mod list is given the okay ๐Ÿ‘Œ by the Forge Gods โœจ
Alas this:

[main/FATAL]: Failed to start the minecraft server
net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [
Spyglass Improvements (spyglass_improvements) has failed to load correctly
ยง7java.lang.RuntimeException: Attempted to load class net/minecraft/client/gui/screens/Screen for invalid dist DEDICATED_SERVER
]
at net.minecraftforge.fml.ModLoader.waitForTransition(ModLoader.java:235) ~[fmlcore-1.18.1-39.0.76.jar%23146!/:?]
at net.minecraftforge.fml.ModLoader.lambda$dispatchAndHandleError$21(ModLoader.java:200) ~[fmlcore-1.18.1-39.0.76.jar%23146!/:?]
at java.util.Optional.ifPresent(Optional.java:178) ~[?:?]
at net.minecraftforge.fml.ModLoader.dispatchAndHandleError(ModLoader.java:200) ~[fmlcore-1.18.1-39.0.76.jar%23146!/:?]
at net.minecraftforge.fml.ModLoader.lambda$gatherAndInitializeMods$11(ModLoader.java:177) ~[fmlcore-1.18.1-39.0.76.jar%23146!/:?]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
at net.minecraftforge.fml.ModLoader.gatherAndInitializeMods(ModLoader.java:177) ~[fmlcore-1.18.1-39.0.76.jar%23146!/:?]
at net.minecraftforge.server.loading.ServerModLoader.load(ServerModLoader.java:46) ~[forge-1.18.1-39.0.76-universal.jar%23149!/:?]
at net.minecraft.server.Main.main(Main.java:104) ~[server-1.18.1-20211210.034407-srg.jar%23145!/:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
at net.minecraftforge.fml.loading.targets.CommonServerLaunchHandler.lambda$launchService$0(CommonServerLaunchHandler.java:46) ~[fmlloader-1.18.1-39.0.76.jar%2323!/:?]
at cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:37) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.modlauncher.Launcher.run(Launcher.java:106) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-9.1.0.jar%235!/:?]
at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:149) [bootstraplauncher-1.0.0.jar:?]

So. I disable your mod completely, everything works.
Help?

Spyglass Improvements 1.1 forge
JDK 17
Minecraft 1.18.1
Forge Modloader 39.0.76
Windows 10 x64 21H1 19043.1526
Windows 10 x64 21H2 19044.1526

request: be able to disable Spyglass from switching to first person

when you are in third person (back/front) and use Spyglass, you automatically go to first person

2023-11-27_19 25 28
2023-11-27_19 25 30

and this is bad for content creators, who like to zoom in on the face, doing a close-up
like this:

2023-11-27_19 27 53_huge

that's why I ask that a configuration be added to disable this function, and also the function of making the player invisible when using the spyglass

if you will accept this request, pls make an update to Fabric 1.20.1

Disable inital zoom in animation

I don't like having an animation for the initial zoom in, it makes me feel dizzy.

An option to disable it would be appreciated.

This should be treated separately from the smoothing animation done when increasing/decreasing FOV while already zoomed in.

Support spyglass akimbo for wider field of view xd

When a player has two spyglasses, one in each hand, bring two of them to the face and show two zooms next to each other like binoculars would do xd

It would be a funny but useful and balanced way of using whole screen to draw without black boxes on the sides xd

There would be 2 separate frames visible next to each other.

You could treat it as an easter egg :D

[Feature Suggestion] Crossbow Spyglass Sight

would it be possible to make this work with a crossbow in main hand for a sniper feature?
as if when toggeld the spyglass "gets mounted on" the crossbow.
would be a nice feature for the crossbow only!

Conflict with Spyglass Astronomy

java.lang.RuntimeException: Mixin transformation of net.minecraft.class_329 failed
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:427)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:112)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at net.minecraft.class_310.(class_310.java:606)
at net.minecraft.client.main.Main.method_44604(Main.java:205)
at net.minecraft.client.main.Main.main(Main.java:51)
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError: An unexpected critical error was encountered
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:392)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClass(MixinTransformer.java:234)
at org.spongepowered.asm.mixin.transformer.MixinTransformer.transformClassBytes(MixinTransformer.java:202)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:422)
... 10 more
Caused by: org.spongepowered.asm.mixin.injection.throwables.InjectionError: Critical injection failure: Redirector swapTexture(ILnet/minecraft/class_2960;)V in spyglass_astronomy.mixins.json:InGameHudMixin from mod spyglass_astronomy failed injection check, (0/1) succeeded. Scanned 1 target(s). Using refmap spyglass_astronomy-refmap.json
at org.spongepowered.asm.mixin.injection.struct.InjectionInfo.postInject(InjectionInfo.java:468)
at org.spongepowered.asm.mixin.transformer.MixinTargetContext.applyInjections(MixinTargetContext.java:1385)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyInjections(MixinApplicatorStandard.java:1052)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.applyMixin(MixinApplicatorStandard.java:400)
at org.spongepowered.asm.mixin.transformer.MixinApplicatorStandard.apply(MixinApplicatorStandard.java:325)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.apply(TargetClassContext.java:421)
at org.spongepowered.asm.mixin.transformer.TargetClassContext.applyMixins(TargetClassContext.java:403)
at org.spongepowered.asm.mixin.transformer.MixinProcessor.applyMixins(MixinProcessor.java:363)
... 13 more

The issue on Spyglass Astronomy: Nettakrim/Spyglass-Astronomy#8

Allow to zoom in more [Feature request]

As simple as it sounds. We already have an ability to zoom out with a mouse wheel. It would be nice to also zoom in like twice as more, not by default but with a mouse wheel as well. For me the maximum level zoom isn't enough cause I play with extreme render distances and want to see my base from far far away.

no animation

when the spyglass is used from the inventory it get's to the offhand but the animation doesn't happen (the player model just holds the spyglass instead of looking thru it

Spyglass zoom bugs out if default keybind is changed (Forge 1.18.2)

With the keybind set to its default, the mod functions as intended. When the keybind is changed, the mod is borderline unusable. While the scroll-to-zoom and no-crosshair features still work as normal, pressing the changed keybind causes the screen to zoom in and out a few times and not display the spyglass overlay. Also, if the spyglass is in your inventory and not your hotbar, it will not even attempt to move the spyglass to your offhand as normal. The zoom keybind only functions normally if you already have the spyglass in your hand or if you are in Creative mode and don't have a spyglass in your inventory at all.

If needed, I can record and post a video showing more details.

Also, a quick feature request: When using the hotkey to pull the spyglass from your inventory into your offhand, swap the items back after releasing the hotkey. If that isn't possible, it would at least be helpful to have a config option making it so you can only use the hotkey to access your spyglass if it is in your hotbar so that you don't have to rearrange your items when you're done with the spyglass.

[Suggestion]: Curios support.

Adding optional support for the curios and trinkets mod. Adding a slot that has the same functionality as having it in your hotbar quick access).

1.18.2 Forge Keybind Bug

Hello, whenever I use the keybind to use the spyglass, it works for a split second and then goes back to my previous slot. It only works while in my hotbar as well. All other aspects of the mod work.

Button position incompatibility with Client Tweaks

Hello, the mod Client Tweaks presents two audio slider - the button from Spyglass Improvements goes over this.
Here is the mod: https://modrinth.com/mod/client-tweaks

2023-01-16_13 28 21
2023-01-16_13 28 35

It's great that I can already deactivate this button in the settings, but a more elegant way would be better.
Maybe turn this big button into a micro button, like from Puzzle, the button you can see on the left top side.
Thanks already ๐Ÿ˜Š

@BlayTheNinth maybe you can look into that as well.

[1.19.2] Crash when Controllable mod is installed

I'm not sure if it is on Spyglass Improvement's or Controllable's side so apologies in advance.

The game fails to load when these two mods are installed. I tried loading a game with only them and nothing else and the game crashes without making a crashlog.

Used versions:
Minecraft: 1.19.2
Forge: 43.2.11
Spyglass Improvements: [1.19-1.19.4 Forge] Spyglass Improvements 1.4
Controllable: controllable-0.18.0-1.19.2

Here's the log from console, hopefully it'll be of help:
log.txt

Allow rebinding quick access key [Feature request]

Is it possible to rebind the quick access key for this mod when multiple key bindings conflict? Currently, the default key for quick access is 'Z', but I didn't see any choice to be able to change it to another key.

Additional Information:

  • Mod version: 1.20 Forge
  • Minecraft version: 1.20.1

Settings button overlaps the Physics mod button

The settings button for this mod overlaps the settings button for the Physics mod. Both are still clickable, though only in the small area where they don't overlap.

image

Minecraft 1.19
Fabric 0.14.8

Mod List:
fabric-api-0.56.0+1.19
physics-mod-2.7.6-mc-1.19-fabric
spyglass-improvements-1.3+mc1.19+fabric

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.