juandiegoguerra/awesome-books

"Awesome books" is a simple website that displays a list of books and allows you to add and remove books from that list. By building this application, you will learn how to manage data using JavaScript. Thanks to that your website will be more interactive. You will also use a medium-fidelity wireframe to build the UI.

💫 About Me:

🔭 I’m currently studying in Microverse
👯 I’m looking to collaborate on learning projects
🤝 I’m looking for help with front-end development skills
🌱 I’m currently learning front-end development
💬 Ask me about Java or C+
⚡ Fun fact - I'm a gamer and I never give up until I beat the boss!

🌐 Socials:

💻 Tech Stack:

📊 GitHub Stats:

🏆 GitHub Trophies

✍️ Random Dev Quote

---

💰 You can help me by Donating

awesome-books's Issues

Excessive and Unnecessary CSS Tag Usage

You have been doing an amazing job so far. However we got few aspects you can improve and work on:

Currently, your CSS codebase contains a significant number of unnecessary tags, resulting in increased complexity and potential performance issues. This issue aims to address the problem and optimize the usage of tags within our CSS files.

The CSS code currently employs numerous unnecessary tags, such as descendant selectors, overly specific class selectors, and repeated tag selectors. These redundant selectors bloat the codebase, making it harder to understand, modify, and optimize.

Suggested Solution:

• Perform a comprehensive review of our CSS codebase to identify and document instances of unnecessary tag usage.
• Refactor the CSS code by removing redundant tags where possible, while ensuring the desired styles are preserved.
• Consolidate and optimize styles by utilizing more efficient and concise selectors.
• Conduct thorough testing to verify that the changes do not introduce any visual regressions or functional issues.

Morning session

Peer-to-peer review

Juan Diego, you have done a good job so far! ✔️

• The design is clear and nice, and functionality wise is doing what is intended to

Although there are some changes that can be made to improve your project

• I kindly suggest using DOMContentLoaded event instead of 'load', here are more references to the event.

Actual code

Suggested code

window.addEventListener('DOMContentLoaded', loadBooks());

• Also is a good practice to document your code so is easy to read and understand by other people.

Actual code

Suggested code

// Remove book function

  removeBook(index) {
    this.books.splice(index, 1);

• Remember that in order to help the readability of your code it is recommended to put all the variables at the top of your JS file, I kindly suggest making this change.

Actual code

Suggested code

const newTitle = document.getElementById('new-title'); 
const newAuthor = document.getElementById('new-author');
const addButton = document.getElementById('add-button');
const localbooks = localStorage.getItem('books');
const superLibrary = new Library();
const listLink = document.getElementById('list-link');
const addLink = document.getElementById('add-link');
const contactLink = document.getElementById('contact-link');

Keep up the good work, these are minor changes that can help your code shine ⭐