juanpablozunigahidalgo/prj-rev-bwfs-dasmoto

prj-rev-bwfs-dasmoto's Issues

Great: Indentation/alignment

https://github.com/juanpablozunigahidalgo/prj-rev-bwfs-dasmoto/blob/master/Dasmoto's%20Arts%20%26%20Crafts/Index.html#L1-L34

You've done a great job formatting your code into a readable flow!

Subtle: Unclassified divs

https://github.com/juanpablozunigahidalgo/prj-rev-bwfs-dasmoto/blob/master/Dasmoto's%20Arts%20%26%20Crafts/Index.html#L11

I recommend giving divs like the one above a class or an id so that you can easily tell what it does and so you can manipulate it using CSS when necessary.

SUMMARY

Grade: Meets Expectations

This is an awesome take on the project! Your code is easy to read and well organized, which is hugely important. Coding is a collaborative undertaking, so having code that others can comprehend will serve you well as projects become bigger and more complex. Another way to make your code easy to swallow is by using comments, so I'd start developing that habit now as well.

Be wary of repetitious code: you should never be typing the same lines as many times as you do in your CSS file. If you find that happening, think about ways to simplify. On another note, CSS is fun because you can make things your own. I like to use Google Fonts to find interesting fonts, and Coolors.co to generate color palettes that enhance the visual aspect of my projects. Just a thought to bring your apps to a new level! Again, great job here and congratulations!

Simplify: Repetitive CSS

https://github.com/juanpablozunigahidalgo/prj-rev-bwfs-dasmoto/blob/master/Dasmoto's%20Arts%20%26%20Crafts/Resources/css/style.css#L10-L36

If you look carefully, you'll notice that you reuse the same stylings in each of these classes. When you find yourself reusing the same code, it's a sign that you should make a new class with those attributes and apply it to each block. Then, use the classes you've already created for the class-specific stylings (here, background-color).