juanramino/comuni-service

Italian municipality service

comuni-service's Issues

Restart after Update strategy

I see that the command for updating data is:
cd /app/ && npm run update:comuni && pm2 restart comuni-service

So, each time the comuni was updated, the service stopped and restart.
In my opnion this is not the best way to do this, cause all the service flat out and reopen in memory all the Db, each time. Image this in a polling service. And if an error happen and the new file wasn't created? You cannot rollback or restart the service.

So i was thinking about using the --watch option for pm2.
Think about the procedure with this parameter. The comuni.json was update (my last PR) only if there is a true changing event. And the use of the watch parameter can drop the major part of useless "stop and start" procedure.

The problem is:
In this scenario, you should have a static name for the Json, cause the watch parameter do the best watching for a file or a folder. So i propose to change the Env variable name for the file JSON in a static one (comuni.json) for example, in order to accomplish all the strategies i wrote before.

What about?

Add foreign states

Add foreign states data:

• Name
• Italian province ('EE')
• Italian code

It could be nice to find a public URL that show this data and update it ISTAT do with Italian municipality.

For now I find this data (attached)
foreign.json.txt

Not a real test

I see the comuniUpdater.js tests but, in my opinion these are not real tests. There are a few considerationts around this:

• Test should be consistent. This is not true at the moment, cause if you check the updater flow, can pass or not in base of the ISTAT site reachable condition.
• Test should be replicable. Is not true too cause jsonFile is conditional so you cannot run al the tests in the same moment.

What's your opinion?