jubalm/grunt-fontello

grunt task for downloading fonts from fontello.com

grunt-fontello's Issues

Running Grunt task changes config.json indentation

http://fontello.com/ uses spaces, they are changed to tabs

Generated font-files corrupt, don't work in firefox

The generated font-files seem corrupt. In firefox (32.0.3) the fonts don't display anymore. When using the fonts downloaded by hand from fontello they do work.

Generated CSS file has wrong path to the generated font files.

Hi, we found that the path within the generated CSS file is always the same: ../font/[font-name]

If the font generated path is changed via fonts property on the Grunt config it's not being used, leading to a 404 if not manually updated.

Thanks for looking into this!

CSS Class Names Don't Match Config

Not sure if this is technically allowed in the way grunt-fontello is set up, but in the config.json, if you change the css name for an icon, the resulting css retains the original name. For example, Fontello might output this:

    {
        "uid": "9dd9e835aebe1060ba7190ad2b2ed951",
        "css": "search-1",
        "code": 59397,
        "src": "fontawesome"
    },

But I change it to:

    {
        "uid": "9dd9e835aebe1060ba7190ad2b2ed951",
        "css": "search",
        "code": 59397,
        "src": "fontawesome"
    },

And the CSS generated still has "search-1." In this case there are no other instances of "search" in the config file. Are we able to change the class names in this way?

Switching default icon dir

Unless I am mistaken, since the sass files are generated with the json file, there is no way to specify where those files will be placed. The looks for the font files in ../font/ by default.

If you change this dir in the gruntfile to ../fonts/icons/ for example, the icon files are built in the wrong place and not found by the sass because it is still looking for them in ../font/

Is this repository still active?

966fc4c is the most recent commit, and although this was only in June (not that long ago) I feel this repo has lost interest of the creator and maintainer (@brianhelba ?). There are a few open issues that have simple solutions and PRs open to fix them 😞

Therefor I would like to ask @jubalm and/or @brianhelba if they're willing to add me (or anyone interested really) as a contributor or, perhaps, eventransfer ownership to me (or, again, anyone else...).

Given the (public) activity of @jubalm, I also sent the following email to the address stated in the README.md (excluding links):

Hi Jubal Mabaquiao,

My name is Eric Cornelissen, I'm a recent contributor (my github) of your grunt-fontello 
project but was disappointing to find out that the project has lost your interest and
(seemingly) the interest of other maintainers as well.

Therefor I created an issue in the repository addressing my problem. But given your public
activity on Github I also decided to sent you this email.

What I want to ask you is the following:
Would you be interested in either adding me as a contributor, so I can accept PRs, resolve
issues and add code myself. Or, perhaps, even transfer the repository to me (which you can
read more about here). This decision is of course up to you.

I hope to hear from you soon. Kind regards,
Eric Cornelissen

If I don't get any response, I will try to continue development on my own fork. The reason I try this first is because having this name for the plugin is pretty convenient 😅

font src url not modified in the fontello*.css files

It will be great to find a way to reset the urls defined in the fontello*.css files according to the path set with the fonts option.

Better support for grunt-fontello and LESS files

It would be nice if grunt-fontello would work properly. Unfortunately current version 0.1.3 doesn't work for me. It downloads only some files using my config.json.

There is also no LESS support. It would be very useful.

README indicates to use the sass option but it's scss

The documentation indicates we have to use the saas option to activate or deactivate scss file extration. But the option defined in fontello.js (line 120) is scss not sass.

The option name must be change in the doc or in the code.

ttf, woff, woff2 seems to be broken with 0.3.5+

Hi,
downloading fonts with version 0.3.5 or higher results in broken font files. Version 0.3.4 is working fine.

How to get UID for json?

when creating the json file, how do i find the uid for the glyphs. I could not find them on the website. thanks!

how is editing the configuration through the web is supposed to work?

downloading the fonts+css for a custom config.json file i created on http://fontello.com/ works well.

for editing the configuration using the fontello.com webinterface, this grunt-task should display the url.
however, i've no idea how to get the session ID so i can extend a previously generated fontset.

the makefile (https://gist.github.com/puzrin/5537065/) automatically opens the browser using the session id it got from the api
http://fontello.com/49072ec4aa9728894095e6b1c6asdfadf

did i overlook something or is this feature not yet implemented here?

grunt-fontello over proxy

Hi

Is there a way to run your module over a corporate proxy ? :(

I got this pretty clear error :
Creating session ...Error

Error : getaddrinfo ENOTFOUND

I already added my proxy domain/credentials in .npmrc .bowerrc and in PATH system variable and that works well, but is there a solution for your module ?

Thanks for this promising module anyways !

Npm out of date; documentation issues

Looks like the version out on npm dates to 2013-11-15, while there are fixes on the repo not represented.

Specifically, it appears that the fix for actually outputting .css files instead of .scss is not there. Also README.md refers to an options.sass switch, which doesn't seem to exist...

Can you push the latest stuff to npm, if it's working?

Npm out of date

Hi @jubalm!

The last version installed from NPM is not the same from this repo.

I'm having a problem with the code installed through the NPM, is not generating the file _fontello-codes.scss, but if I use the code from this repository it works normally.

Wrong boolean check of options.scss

Currently, you'll have to set scss: true to actually get .css files.
The culprit: https://github.com/jubalm/grunt-fontello/blob/master/tasks/lib/fontello.js#L120

Should be the other way around, I guess?

Outdated needle

Hey @jubalm,

As a related issue, package.json uses 'needle', which in its old version uses an old version of 'qs'. This causes this error:

Insight-0 Grunt :: .../node_modules/grunt-fontello/node_modules/needle/node_modules/qs/lib/index.js:5
Insight-0 const Stringify = require('./stringify');
Insight-0 ^^^^^

Because strict mode can't use const.

I think updating package.json's use of needle to the latest ~0.11.0 would resolve this issue.

Thanks!

Ryan

Multiple runs of task are needed to fetch all files

I had to run the grunt fontello task 3+ times to get all of the files to appear in my CSS directory. The first time, I only got codes and codes-ie7. The second time, I got animations, and then after a couple more runs I had everything.

files prefix

Hello,
is it possible to chage the css/font prefix ?
I'd like to get test.css, test-ie7.css and so on instead of fontello.css, fontello-ie7.css but I can't find a way to do so

thanks

Allow regular expression in the exclude options

Add functionality to allow the usage of regular expression in the exclude option, for example:

fontello: {
  options: {
    exclude: [
      'animation.css',
      /fontello-ie7*.css/ // Excludes fontello-ie7.css and fontello-ie7-codes.css
    ] 
  }
}

Fatal error: invalid signature: 0x3430345b

When running the grunt task, I get the following error:
Fatal error: invalid signature: 0x3430345b
Here is my config:
fontello: {
dist: {
options: {
config : 'client/config.json',
fonts : 'client/fonts',
scss : true
}
}
}

Choosing option.sass:false still outputs scss files

autoprefixer-like browser support rules

Fontello generates a lot of data including some ie7 fixes and 4 font formats.
That's not always what is needed if a project supports only modern browsers - those browsers can get only woff, other formats may be omitted.

I described my case in the fontello/fontello#338 which was closed as out of fontello scope.

I wonder if integrating browser support config (presumably, but not necessarily the one mentioned in the issue above used by autoprefixer) would be a welcome feature for grunt-fontello or should I try to implement this as a distinct task. What do you think?

Woff2-file missing

The _fontello.scss file references the .woff2 font file, however the file itself is not added. This leads to a "404 not found" on browsers supporting woff2.

npm vulnerability

High Arbitrary File Overwrite
Package fstream
Patched in >=1.0.12
Dependency of grunt-fontello [dev]
Path grunt-fontello > unzip > fstream
More info https://npmjs.com/advisories/886