Giter Site home page Giter Site logo

Comments (8)

Juerd avatar Juerd commented on August 23, 2024

from esp-wifisettings.

JoaquimBoavida avatar JoaquimBoavida commented on August 23, 2024

Thanks for you fast reply. I will do that.
One other question. The "Restart device" button does not really works in my case. I have to hardware reset (or power cycle) to effectively restart. When i press restart, the integrated LED flashes for some milliseconds but the device does not restart. I'm using WEMOS LOLIN D1 mini (ESP8266).
Thanks again for you help and your library.

from esp-wifisettings.

DTTerastar avatar DTTerastar commented on August 23, 2024

My fork can do this

from esp-wifisettings.

Juerd avatar Juerd commented on August 23, 2024

@DTTerastar You have an interesting approach to open source. You fork a project, then don't contribute anything back, but you do use the original project to advertise the fork.

I like some changes you made and will probably reintegrate them. However, it would have been nice if you had contacted me beforehand because I'll do some things differently and there will now be a split in the road forever.

The license absolutely allows what you're doing but I'm not very happy with it. Forking is great for an experimental branch or when the original project is dead or doesn't want any of your changes, but you seem to be taking forking as the FIRST option, and that's just annoying.

from esp-wifisettings.

DTTerastar avatar DTTerastar commented on August 23, 2024

@DTTerastar You have an interesting approach to open source. You fork a project, then don't contribute anything back, but you do use the original project to advertise the fork.

I like some changes you made and will probably reintegrate them. However, it would have been nice if you had contacted me beforehand because I'll do some things differently and there will now be a split in the road forever.

The license absolutely allows what you're doing but I'm not very happy with it. Forking is great for an experimental branch or when the original project is dead or doesn't want any of your changes, but you seem to be taking forking as the FIRST option, and that's just annoying.

I actually did attempt to contribute back and you didn't want it. My response here was to inform you that I had added it. If you would like me to contribute it back, I am happy to do so. But I don't want to waste my time if you don't want it.

from esp-wifisettings.

Juerd avatar Juerd commented on August 23, 2024

@DTTerastar My apologies, you did indeed contribute PR #23; I neglected to check the closed PRs. As you can tell there are several things I liked and some that needed work. I don't know why you chose to close that PR without opening a new one as you had suggested in your comment there.

In any case, I'll close this issue for now as the question has been answered.

from esp-wifisettings.

DTTerastar avatar DTTerastar commented on August 23, 2024

I have definitely taken my fork down a road that I don't think you want. BUT I can contribute the dropdown code if you'd like. Would you like that?

from esp-wifisettings.

JoaquimBoavida avatar JoaquimBoavida commented on August 23, 2024

from esp-wifisettings.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.