Comments (8)
from esp-wifisettings.
Thanks for you fast reply. I will do that.
One other question. The "Restart device" button does not really works in my case. I have to hardware reset (or power cycle) to effectively restart. When i press restart, the integrated LED flashes for some milliseconds but the device does not restart. I'm using WEMOS LOLIN D1 mini (ESP8266).
Thanks again for you help and your library.
from esp-wifisettings.
My fork can do this
from esp-wifisettings.
@DTTerastar You have an interesting approach to open source. You fork a project, then don't contribute anything back, but you do use the original project to advertise the fork.
I like some changes you made and will probably reintegrate them. However, it would have been nice if you had contacted me beforehand because I'll do some things differently and there will now be a split in the road forever.
The license absolutely allows what you're doing but I'm not very happy with it. Forking is great for an experimental branch or when the original project is dead or doesn't want any of your changes, but you seem to be taking forking as the FIRST option, and that's just annoying.
from esp-wifisettings.
@DTTerastar You have an interesting approach to open source. You fork a project, then don't contribute anything back, but you do use the original project to advertise the fork.
I like some changes you made and will probably reintegrate them. However, it would have been nice if you had contacted me beforehand because I'll do some things differently and there will now be a split in the road forever.
The license absolutely allows what you're doing but I'm not very happy with it. Forking is great for an experimental branch or when the original project is dead or doesn't want any of your changes, but you seem to be taking forking as the FIRST option, and that's just annoying.
I actually did attempt to contribute back and you didn't want it. My response here was to inform you that I had added it. If you would like me to contribute it back, I am happy to do so. But I don't want to waste my time if you don't want it.
from esp-wifisettings.
@DTTerastar My apologies, you did indeed contribute PR #23; I neglected to check the closed PRs. As you can tell there are several things I liked and some that needed work. I don't know why you chose to close that PR without opening a new one as you had suggested in your comment there.
In any case, I'll close this issue for now as the question has been answered.
from esp-wifisettings.
I have definitely taken my fork down a road that I don't think you want. BUT I can contribute the dropdown code if you'd like. Would you like that?
from esp-wifisettings.
from esp-wifisettings.
Related Issues (19)
- Warning in ESP8266 HOT 1
- Feature Request: Manual SSID HOT 3
- web interface HOT 4
- WiFiSettings.string() seems to encode the string in some way HOT 2
- WPS HOT 2
- MQTT client, PubSubClient HOT 1
- Compilation error with platform espressif8266 version 3.1.0 HOT 4
- Getting 255.255.255.255 as IP address HOT 4
- Didn't work with ESP32 C3 version HOT 12
- ESP32 does not connect unless restarted through portal HOT 2
- Wifi AP hostname HOT 4
- Cannot connect to soft AP after .portal() is called HOT 7
- Compile error with expansion of macro 'F' HOT 4
- Make filesystem configurable
- Having custom password fields in the AP config replace password with ***********s HOT 4
- WDT conflict with ESP32 support v3.x.x HOT 1
- SSID with apostrophe is truncated HOT 2
- arduino-esp32: Local IP is 255.255.255.255 after connection succeeds HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esp-wifisettings.