juice49/expandobem

✨ The Web and Stuff

I like to make things—usually with web technologies, and usually for the web.

expandobem's Issues

Typo in bin.js

'use strict';

Simple Test fails (gulp)

Hello,

I have my test.jade with:

h1 Test!

when running it like this:

gulp.task('jade', function () {
  return gulp.src('test.jade')
    .pipe(jade({ pretty: true }))
    .pipe(transform(expandobem.processStream))
    .pipe(gulp.dest('html'));
});

the resulting HTML looks like... this:

<h11>Test!</h1>

With proper doctype, head, body, etc. it works as it should, by the way.

processStream error without giving options

Hello again,

I get the following error when trying to just use expandobem.processStream without any options:

/.../node_modules/expandobem/index.js:168
        includes(singleClass, options.syntax.element) ||
                                            ^
TypeError: Cannot read property 'element' of undefined

However, when passing the default options through, everything works fine, e.g.:

    .pipe(transform(expandobem.processStream({
      syntax: {
        element: '__',
        modifier: '--'
      }
    })))

Support class grouping

I'd like to support class grouping, similarly to that described by Harry Roberts.

Based on Harry's example:

<div class='[ foo  bar ]  baz'>

Would compile to:

<div class='foo foo--bar baz'>

My current idea is to take the first class from the group and use it as the block/element qualifier, with all following classes in the group being modifiers.

This would be an opt in compile mode. I don't think the group syntax needs to be configurable; I'm inclined to just use [] for simplicity.

Custom modifier syntax always replaced with `--`

ExpandOBem will correctly recognise and transform classes with custom modifier syntax, but always uses -- to join output classes.

For example, compiling the class attribute foo@@bar with custom modifier syntax set to @@ results in foo foo--bar. The output should be foo foo@@bar.