jule64/binancetrader

A fast and minimalist front end to trade cryptos on Binance

binancetrader's Issues

Enable /USDT tickers

Currently the app works only for tickers denominated in BUSD. So for example ETH/BUSD

While this works for most coins it doesn't work for coins listed against other stable coins (or any denominator other than BUSD for that matter), for example ARB/USDT.

So by this change we want to fix the issue for the USDT case first, as this will take care of most of the tickers that are currently not listed in BUSD. Later we can generalise the logic so that the app works for any denominator.

Fix wrong ticker balance when order is executed in multiple slices

We currently use the 'quantity' field of the order execution confirmation to update the ticker balance in the UI (see 'orders:fill' event). This is wrong as the quantity is the original order quantity not the executed quantity. This is a problem when an order is executed in multiple slices, as usually happens with limit orders, as now we update the ticker balance with the original quantity every time a slice is executed. This cause the final displayed balance to be incorrect.

Using the 'lastTradeQuantity' value of the order confirmation instead should fix the problem

Fix ticker position not showing when ticker is added via the "Add ticker" function

When a ticker is added via the "Add ticker" button, any existing position in that ticker doesn't display on the UI when it should.
Similarly if a user has no prior position in a ticker and adds that ticker using the "Add ticker" function, then any position he opens afterwards will not will not be displayed either. See example screenshots below for illustration.

Current workaround is to add the ticker to the static "tickerWatchlist" in appData.json and restart the app so that the ticker gets displayed.

Example replication:

1. User with existing position in SNX/BUSD adds the ticker via the "Add ticker" function:
   

2. SNX ticker is added but user's position is not showing:
   

Persist tickerWatchlist to Sqlite

The tickers watchlist is currently configured in appData.json. We want to have this list in a db table instead.

Since we do not use a db in the project yet I suggest going for SQLite as the db provider however happy to use something else if anyone has knows of a better option.

Persist tickers added via "Add ticker" function

Currently a ticker added to the UI via the "Add ticker" function will disappear from the list on app restart. We want to fix this by persisting the tickers to main watchlist.

Dependency: this feature is dependent on #1 to be implemented first as currently the main watchlist in configured in a json file.