Giter Site home page Giter Site logo

Comments (4)

tshort avatar tshort commented on July 19, 2024

I think I fixed this, but before this is closed, @HarlanH or @doobwa, please check. Tests passed, but I didn't test much beyond trying it on one sub(df).

from dataframes.jl.

doobwa avatar doobwa commented on July 19, 2024

Several of these functions return DataFrames. If provided a GroupedDataFrame, should they return a GroupedDataFrame?

from dataframes.jl.

tshort avatar tshort commented on July 19, 2024

That's a good question, Chris. They probably should if they can. I didn't look in enough detail to see if it's possible. SubDataFrame is our only other AbstractDataFrame right now. For SubDataFrame's, there may not be that much difference between the approaches. We might know better once we have other AbstractDataFrame's like DDataFrame.

from dataframes.jl.

doobwa avatar doobwa commented on July 19, 2024

Looks good for now, though we'll may revisit it once more AbstractDataFrame types are present.

from dataframes.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.