Comments (2)
I wonder if making ProjectTo
look inside containers was a mistake. Maybe it should be content to deal with the outer array here, and assume that whatever rule made the inner arrays knew what it was doing (or called ProjectTo itself)?
That said I don't quite see where this instability is from, why doesn't map
infer if the elements infer?
julia> @code_warntype map(ProjectTo, x)
MethodInstance for map(::Type{ProjectTo}, ::Vector{Vector{Float64}})
from map(f, A::AbstractArray) in Base at abstractarray.jl:2933
Arguments
#self#::Core.Const(map)
f::Type{ProjectTo}
A::Vector{Vector{Float64}}
Body::Union{Vector{ProjectTo{AbstractArray, NamedTuple{(:element, :axes), Tuple{ProjectTo{Float64, NamedTuple{(), Tuple{}}}, Tuple{Base.OneTo{Int64}}}}}}, Vector{Any}}
...
julia> @code_warntype ProjectTo(x[1])
MethodInstance for ProjectTo(::Vector{Float64})
from ProjectTo(x::AbstractArray{T}) where T<:Number in ChainRulesCore at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/projection.jl:200
Static Parameters
T = Float64
Arguments
#self#::Type{ProjectTo}
x::Vector{Float64}
Body::ProjectTo{AbstractArray, NamedTuple{(:element, :axes), Tuple{ProjectTo{Float64, NamedTuple{(), Tuple{}}}, Tuple{Base.OneTo{Int64}}}}}
from chainrulescore.jl.
That said I don't quite see where this instability is from, why doesn't map infer if the elements infer?
I was wondering that. Usually map
infers things nicely 🤷
from chainrulescore.jl.
Related Issues (20)
- `Reusable` and `NonReusable` reverse mode capability
- `test_rrule` fails on the pedagogical example HOT 2
- Precompiling ChainRules stack not defined HOT 3
- Warnings about unused type variable HOT 3
- Document how to define own ProjectTo's
- Document how to construct Wirtinger derivative
- Making `getproperty`, `getindex` and `iterate` more type stable for `Tangent`s HOT 1
- Make ZeroTangent() == 0 HOT 3
- Using the gradient function from Flux / Zygote with a custom rrule HOT 5
- Cannot generate `frule` seed via `one(x)` HOT 1
- overload iszero for Tangent
- `ProjectTo(::AbstractSparseMatrix{Bool})` should be trivial
- No method matching `(::ChainRulesCore.ProjectTo)(::Tuple{Float64})` HOT 9
- ProjectTo causes scalar indexing when taking adjoints of complex CuArray HOT 1
- FAQ Broken Links HOT 3
- (to be deleted)
- Get rid of `MethodError: no method matching iterate(::Nothing)` HOT 1
- tangent_type(primal_type)
- typos in geometric descriptions in the docs HOT 3
- `norm(NoTangent())` causes StackOverflow HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chainrulescore.jl.