junjiehu/cs769-assignments

cs769-assignments

cs769-assignments's Issues

About prepare_submit.py

There are some problems in ‘prepare_submit.py’ . In required_files , we need setup.py, but only setup.sh is given in the assignment.
Besides， if any(file.endswith(s) for s in ['.pdf', '.txt', '.sh', '.py', '.npy']): do not check the '.data' and '.md', this will make the constructed zip file lack necessary files.
I suggest changing it to
if any(file.endswith(s) for s in ['.pdf', '.txt', '.sh', '.py', '.npy', '.data', '.md']):

About updated sanity_check.py

Does the updated sanity_check.py have issues with error tolerance? When my code is testing sanity_check.py, even if the two values ​​differ by 1e-7, they will be considered unequal. Is this because torch.allclose uses the default a_tol (too small)，but just set r_tol ?