junyi-99/mustplus.server

Macau University of Science and Technology Campus Application ( Server )

⚙️ GitHub Analytics

🤝🏻 Connect with Me

mustplus.server's Issues

New features suggested

可以加一个 “知道学生看了哪些通告” 功能

New feature suggested

可以显示期末考试教室和时间座位号

Time-consuming operation

https://github.com/Military-Doctor/MUSTPlus.Server/blob/20c2610ae2e6228e979c54422225c1a360372949/API/COES.py#L90

I did not execute this function, but I can see that this function will take 6 seconds to retrieve the user‘s information.

Each login takes 3 seconds, and you login twice in this function, which means that the function is inefficient.

Please make a change.

Some suggestions for improvement of COES.py

# Author : Aikov
# Time :2019/4/30
# Status:Finished
def get_info(userid, password):
    try:
        student = Student.objects.get(student_id=userid)
    except ObjectDoesNotExist:
        student = Student.objects.create(student_id=userid)
    cookies = get_cookie(userid, password)
    if cookies == 0:
        return 0
    # Find info on personal info
    url = 'https://coes-stud.must.edu.mo/coes/StudentInfo.do'
    r = requests.get(url=url, cookies=cookies)

    # Find Chinese name
    tar = 'Name in Chinese:&nbsp;</td> <td class="blackfont"> '
    pos1 = r.text.find(tar) + tar.__len__()
    pos2 = r.text.find('  </td>', __start=pos1)
    student.name_zh = r.text[pos1:pos2]

    # Find English name
    tar = 'Name in English:&nbsp;</td> <td class="blackfont"> '
    pos1 = r.text.find(tar) + tar.__len__()
    pos2 = r.text.find('  </td>', __start=pos1)
    student.name_en = r.text[pos1:pos2]

    # Find sex
    tar = 'Gender:&nbsp;</td> <td class="blackfont">'
    pos1 = r.text.find(tar) + tar.__len__()
    pos2 = r.text.find('</td>', __start=pos1)
    student.sex = r.text[pos1:pos2]
    

student.sex 是 Boolean 属性，r.text[:] 是 str

    # Find birthday
    tar = 'Date of Birth:&nbsp;</td> <td class="blackfont">'
    pos1 = r.text.find(tar) + tar.__len__()
    pos2 = r.text.find('</td>', __start=pos1)
    date = r.text[pos1:pos2]
    date = date.split('/')
    student.birthday.day = int(date[0])
    student.birthday.mouth = int(date[1])
    student.birthday.year = int(date[2])

    # Find info on study plan
    url = 'https://coes-stud.must.edu.mo/coes/StudyPlanGroup.do'
    r = requests.get(url=url, cookies=cookies)

    # Find Faculty
    tar = 'Faculty:&nbsp;</td> <td class="blackfont">'
    pos1 = r.text.find(tar) + tar.__len__()
    pos2 = r.text.find('</td>', __start=pos1)
    name = r.text[pos1:pos2]
    try:
        faculty = Faculty.objects.get(name_en=name)
    except ObjectDoesNotExist:
        faculty = Faculty.objects.get(name_zh=name) 

如果这里也 raise 了一个 ObjectDoesNotExist 怎么办； 还有可能学校加新的faculty而我们的数据库里没有，也会导致崩溃。继续向下看，

    student.faculty_id = faculty.id

    # Find Major
    tar = 'Major: '
    pos = r.text.find(tar)
    # 不知道为什么两个tar之间在源码里有一个回车，这样规避一下
    tar = '</td> <td class="blackfont">  '
    pos1 = r.text.find(tar, __start=pos) + tar.__len__()
    pos2 = r.text.find('  </td>', __start=pos1)
    name = r.text[pos1:pos2]
    try:
        major = Major.objects.get(name_en=name)
    except ObjectDoesNotExist:
        major = Major.objects.get(name_zh=name) 

同理。可能逻辑上不是中文就是英文，但是实际情况非常复杂，COES可能会出问题，那么COES显示不全的时候这里就会爆炸。还有可能学校加新的major数据库里没有，也会导致崩溃

在这里不要取巧，该 catch 的 Exception 最好都 catch 到

    student.major_id = major.id
    # 已经从COES爬完了个人信息
    student.save()
    url = 'https://coes-stud.must.edu.mo/coes/logout.do' 
    requests.post(url=url, cookies=r.cookies)

如果上面text.find部分出了差错，就无法退出COES了。不要相信COES是稳定的，要认为所有东西都不可靠，我们要保证用户使用我们的服务不会出现问题。

可以尝试使用修饰器去修饰这些函数（比如写一个ensure_logout修饰器）

让这个修饰器去 handle 可能存在的 exception

客户端提议

加入防伪课表截图的功能

New circumstances that may not be considered

The user changed the password while using the MUST+

Database improvement

StudentTakeCourse relationship should add a field semester

关于朋友圈

加一个设备显示