jupyter-naas/naas-models

naas-models's Issues

Automatic deployments to pypi

We need to auto deploy naas-models version to pypi.

Create Space model with validation and all build and release logic

We need to create the Space model with it's validation logic. This also needs to build the proto files into the Python classes using the pydantic BaseModel (there is a protobuf to pydantic module out there).

You also need to setup Semantic release on this project, just for versioning, not pushing on pypi as it's a private repo.

You must create a Makefile and leverage docker to install protoc and needed software to build the proto

As a dev, I need to design the workflow.proto

Now that the scheduler-v2-poc is done, we can proceed to the implementation of that in the api.

For that we need to create the Workflow.proto that will contain the resources needed to build a DAG Workflow that will run in Argo Workflow.

We should follow the following documentation from Argo: https://argoproj.github.io/argo-workflows/walk-through/the-structure-of-workflow-specs/

Resources that should be taken in account for creating the protos are:

• io.argoproj.workflow.v1alpha1.Workflow
• io.argoproj.workflow.v1alpha1.WorkflowSpec
• io.argoproj.workflow.v1alpha1.CronWorkflow
• io.argoproj.workflow.v1alpha1.WorkflowSpec
• io.argoproj.workflow.v1alpha1.Template

We must also be able to specify metadata but this will mainly be for us in the backend to pinpoint to which users are the workflow tied to etc.

As part of this you should also create all the CRUD messages (DTO) like WorkflowCreationRequest, WorkflowDeletionRequest etc ...

@viniciusdc please let me know if I am forgetting anything.

fix: Generate and integration to naas-api-ce

Issue Description

Description

After installing grpcio-tools, there are issues with the make, generate, and target commands, as well as problems with the Dockerfile building. Although bumping everything seemed to resolve some issues, it led to the naas-api-ce failing. This issue aims to fix the mentioned problems and update naas-api-ce to resolve the failures.

As a dev, I need to make sure error codes does not overlap in proto files

Issue Description

Problem

When defining error codes in proto files, there is a risk of overlapping codes which can lead to confusion and misinterpretation of error responses. This can be a critical issue, especially when handling HTTP status codes.

Solution

To prevent this issue, we need to establish and maintain a system or protocol for managing and assigning unique error codes across all our proto files. This system should ensure that each error code is distinct and clearly documented to prevent any ambiguity.

Action Items

• Review all existing proto files to identify potential overlaps in error codes.
• Develop a standardized approach for assigning error codes in proto files.
• Update documentation to include guidelines on how to assign unique error codes and the importance of avoiding overlap.
• Conduct a thorough review of all future proto file changes to ensure compliance with the new error code management protocol.

By addressing this issue proactively, we can enhance the clarity and reliability of our error handling mechanisms within the project.

feat: Create protos for chat, messages and models

We need to have models being created for chats, models and messages

fix: naas-models install via pip

When I try to install naas-models, and therefore, naas-python, I get the following error:

I think that in naas_models/python/ we need to add a init.py file.