Giter Site home page Giter Site logo

Fix alt heys about cpp-terminal HOT 5 CLOSED

jupyter-xeus avatar jupyter-xeus commented on May 24, 2024
Fix alt heys

from cpp-terminal.

Comments (5)

certik avatar certik commented on May 24, 2024 1

I see. Yes, we can design a new approach.

from cpp-terminal.

MCWertGaming avatar MCWertGaming commented on May 24, 2024

update on this: the macros are broken and do really nothing actually. first of all ALT keys return a value below zero which gets casted into a unsigned char (which can't be negative). Then we calculate it + 128 and cast it back into an char (which can just hold up to 127). So in the end it somehow still provides the case Key < 0.

@certik would it be enough to just check if the key number is below zero? I haven't found another key that is similar to that. Otherwise i could check on the actual value of the alt key (probably a number that's the char + some value) and create a function you can just easily use.

Also CTRL+I returns TAB key in the keys demo. I would fix that as well.

from cpp-terminal.

certik avatar certik commented on May 24, 2024

I don't have an opinion. If there is a runtime error that we need to fix it. As we discussed, we should move from macros to functions. There was some issue that it required a significant rewrite of some switch statements in one of the examples, but I haven't had time to look into that.

from cpp-terminal.

MCWertGaming avatar MCWertGaming commented on May 24, 2024

yeah but I have an idea to skip the rewrite. Also my change doesn't work that well as I have just changed the not working macro into an not working inline function. We need an different option here. Also the keys example is interpreting the ALT keys differently than the promt. That's why one has a critical problem and the other one does not. I would suggest to take a entirely different approach here. But we can merge my first try of course, I would change that later on then.

from cpp-terminal.

MCWertGaming avatar MCWertGaming commented on May 24, 2024

Done! #113 provides a new approach.

from cpp-terminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.