Add a make install target to install into a prefix

[jupyter-xeus]

Add a make install target to install into a prefix

[JohanMabille]

I like cpp-terminal, that would be consistent with other conda packages such as cpp-filesystem

[certik]

Yes, of course. So far I just copied the header files to my projects but I agree, let's just install it.

…

On Thu, May 14, 2020, at 1:45 AM, Wolf Vollprecht wrote: ... or use CMake? That would make it easy to have terminal on conda-forge, and we could use it right away in mamba. I just tested it and it looks very impressive and also very much like what we need so I am happy to help out here. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/certik/terminal/issues/40>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFAWAMGPN2PLEA632ZTXTRROOP5ANCNFSM4NAOAFJA>.

[wolfv]

@certik I am looking again at this to properly handle the yes/no prompts in mamba :) especially CTRL+C during a wait for y/N isn't handled correctly in mamba right now. Once you have the installation sorted out we can make a nice conda package and I can use it right away.

[certik]

So Ctrl-C it normally handled by the system I believe, and there is a way to turn it off, I think this line does it:

https://github.com/certik/terminal/blob/69ee07e5aee2fe4c4bff4fa164364ec049c66069/terminal_base.h#L106

If you are ready to use it, I can get it done today. I'll work on this.

[certik]

CMake build system introduced in #41.

[certik]

This is now fixed in master.

I am thinking there is no need for multiple header files. I think this library even when fully developed can fit into just one header file. Let's call it terminal.h.

Should it go into a subdirectory such as terminal/terminal.h, or directly as terminal.h? What is the standard convention for C++?

[wolfv]

I believe a subdirectory might be nice to not clutter the include folder, and not have potential conflicts with other packages. terminal is a pretty generic term I guess. might be worth it to use cpp-terminal/terminal.hpp?

Once you tag a release I am happy to make the conda package :)

[certik]

Perfect. I moved it under cpp-terminal in #43.

I still have to create a CMake package to install so that other projects can easily depend on this. Otherwise it's ready.

[certik]

The CMake package was created in #45 and #46.

[certik]

@wolfv here is the tag: https://github.com/certik/terminal/releases/tag/v0.1.0

Please keep me updated and open issues for any problems you discover.