just-js/v8

v8 monolithic library builds for common platforms :rocket:

v8's Issues

Undefined symbols when linking against the Windows lib

I'm linking against the monolith lib from libv8_monolith-win-x64.lib.gz in the 1.0.0 release and am getting the following undefined symbols.

My includes:

#include "v8.h"
#include "libplatform/libplatform.h"

My code:

    Platform = v8::platform::NewDefaultPlatform();

I get the following undefined functions

1>Module.WebUI.cpp.obj : error LNK2019: unresolved external symbol "unsigned __int64 * __cdecl v8::api_internal::GlobalizeReference(class v8::internal::Isolate *,unsigned __int64)" (?GlobalizeReference@api_internal@v8@@YAPEA_KPEAVIsolate@internal@2@_K@Z) referenced in function "public: __cdecl v8pp::detail::object_registry<struct v8pp::raw_ptr_traits>::object_registry<struct v8pp::raw_ptr_traits>(class v8::Isolate *,class v8pp::detail::type_info const &,class std::function<void __cdecl(class v8::Isolate *,void * const &)> &&)" (??0?$object_registry@Uraw_ptr_traits@v8pp@@@detail@v8pp@@QEAA@PEAVIsolate@v8@@AEBVtype_info@12@$$QEAV?$function@$$A6AXPEAVIsolate@v8@@AEBQEAX@Z@std@@@Z)
1>Module.WebUI.cpp.obj : error LNK2019: unresolved external symbol "private: void __cdecl v8::ScriptOrigin::VerifyHostDefinedOptions(void)const " (?VerifyHostDefinedOptions@ScriptOrigin@v8@@AEBAXXZ) referenced in function "public: class v8::Local<class v8::Value> __cdecl v8pp::context::run_file(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?run_file@context@v8pp@@QEAA?AV?$Local@VValue@v8@@@v8@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>Module.WebUI.cpp.obj : error LNK2019: unresolved external symbol "class std::unique_ptr<class v8::Platform,struct std::default_delete<class v8::Platform> > __cdecl v8::platform::NewDefaultPlatform(int,enum v8::platform::IdleTaskSupport,enum v8::platform::InProcessStackDumping,class std::unique_ptr<class v8::TracingController,struct std::default_delete<class v8::TracingController> >,enum v8::platform::PriorityMode)" (?NewDefaultPlatform@platform@v8@@YA?AV?$unique_ptr@VPlatform@v8@@U?$default_delete@VPlatform@v8@@@std@@@std@@HW4IdleTaskSupport@12@W4InProcessStackDumping@12@V?$unique_ptr@VTracingController@v8@@U?$default_delete@VTracingController@v8@@@std@@@4@W4PriorityMode@12@@Z) referenced in function "public: virtual void __cdecl FWebUIModule::StartupModule(void)" (?StartupModule@FWebUIModule@@UEAAXXZ)

Extracting `libv8_monolith-win-x64.lib.gz` without additional dependencies on Windows

Hello! Thanks a lot for building this project. 🙏

I'm using this in a project on Windows. I wanted to extract libv8_monolith-win-x64.lib.gz using the built-in tar command (it is natively available on Windows) but I get this error:

> tar -xzvf libv8_monolith-win-x64.lib.gz
tar: Removing leading '/' from member names
x .: Can't remove already-existing dir: Permission denied
x .: Can't remove already-existing dir: Permission denied
tar: Invalid string table
tar: Error exit delayed from previous errors.

Any thoughts on how to fix this error? I was wondering if we could use tar to create the file in

v8/.github/workflows/main.yml

Line 251 in f575d18

gzip -9 -c v8/out.gn/${{ matrix.platform }}.release/obj/v8_monolith.lib > libv8_monolith-win-${{ matrix.platform }}.lib.gz

, just like how the include headers are compressed in

v8/.github/workflows/main.yml

Line 42 in f575d18

tar -zcvf include.tar.gz v8/include

, which can be extracted using tar without errors.

Or perhaps the gzip step could be removed? WDYT?