justintadlock/hybrid-base

A base theme for building with the Hybrid Core framework.

Gatsby + Cosmic JS

This repo contains an example blog website that is built with Gatsby, and Cosmic JS.

See live demo hosted on Netlify

Uses the Cosmic JS Gatsby Source Plugin

Prerequisites

• Node (I recommend using v8.2.0 or higher)
• Gatsby CLI

Install

# Make sure that you have the Gatsby CLI program installed
npm install --global gatsby-cli

# run from your CLI
gatsby new gatsby-example-blog https://github.com/cosmicjs/gatsby-blog-cosmicjs

In gatsby-config.js you need to add configuration for your Cosmic JS Bucket

{
  resolve: 'gatsby-source-cosmicjs',
  options: {
    bucketSlug: '', /* bucket slug */
    objectTypes: ['posts', 'settings'], /* object slugs you want to populate */
    apiAccess: {
      read_key: '', /* optional */
    }
  }
},

Then

# Then you can run it by
cd gatsby-example-blog
npm run develop

hybrid-base's Issues

No markup for selector #footer .copyright {

There's no markup in the html for the selector: #footer .copyright {}

May be remove redundant selector?

library @ d08d424 points to Hybrid-Core 1.1 ? AND "You are not currently on a branch" with git pull in directory library.

I just cloned hybrid-base :

cd wp-content/themes
git clone --recursive git://github.com/justintadlock/hybrid-base.git hybrid-base
git add hybrid-base/

But library @ d08d424 points to Hybrid-Core 1.1.
Is this intentional?

Also when I cd library and then git pull I get this message :

You are not currently on a branch. Please specify which
branch you want to merge with. See git-pull(1) for details.

    git pull <remote> <branch>

hentry markup class should be changed to entry

Hybrid Based does not seem to render articles with hentry class. The CSS selector should use entry instead of hentry.

content.php: why don't "entry-summary", "entry-footer" deserve hybrid_attr() treatment?

Oversight or a reasoned decision?

Missing CSS selectors for new elements / classes

Hybrid Base could use some classes like:
archive-header, archive-title, archive-decsription

and #menu- li:hover ul <-this is required to show the sub-menu on hover.

loop-nav: why exclude custom post types from navigation?

https://github.com/justintadlock/hybrid-base/blob/master/misc/loop-nav.php#L1

You're using this elsewhere

is_singular( get_post_type() )

Why not here for loop-nav?

BTW what's the difference between the above and just

is_singular()

Archive header on search page

hybrid_is_plural() is true if is_search() is true which means that archive-header.php is loaded on the search results page. This template uses the_archive_title() which doesn't handle search. It also tries to get an archive description on the search page.

loop-meta.php closing <div>

Hi Justin, just wanted to let you know at the bottom of loop-meta.php the

is opening instead of closing

misc/archive-header.php: why exclude is_paged() from get_the_archive_description()?

In my use case it creates an awkward experience when the clarity copywriting up top disappears just because switching pages. Is there something I'm missing about why this is the default?

Make header.php compatible for no custom-header support

The theme fails to display the header is the custom-header support is removed. I think this code should fix it.

header.php: line 20
<?php if ( (current_theme_supports('custom-header') && display_header_text()) || ! current_theme_supports('custom-header') ) : // If user chooses to display header

Update for HC 1.6

Hey Justin,

Will HB be updated to work with 1.6? Just asking for others who may be confused when they get errors because of the post-format changes.

Add shortcut icon support?

"ack shortcut" doesn't reveal anything in hybrid-core either, so thought I'd find out what your stance is on adding some streamlined add_theme_support type thing for a favicon?

 add_filter( "wp_head", function() {
     printf( '<link rel="shortcut icon" href="%s" type="image/x-icon" />', get_stylesheet_directory_uri() . "/img/favicon.ico" );
 } );

works but why keep repeating that in child themes. Thoughts?

loop-nav: should .previous be .prev?

This is to eliminate the difference with paginate_links()

http://core.trac.wordpress.org/browser/tags/3.6.1/wp-includes/general-template.php#L1994

AFAiCS theme's navigation class should follow core naming, so we don't have to chase this in styling. Am I missing anything significant with this reasoning?